[wpt-sync] Sync PR 45729 - Revert "Fix popover-light-dismiss.html"
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(Not tracked)
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 45729 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/45729
Details from upstream follow.
luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> wrote:
Revert "Fix popover-light-dismiss.html"
This reverts commit 02d797ea20afb35ef326458b54de758da8f492a5.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5639081310552064Sample build with failed test: https://ci.chromium.org/b/8750553163900166785
Affected test(s):
ninja://:blink_wpt_tests/external/wpt/html/semantics/popovers/popover-light-dismiss.html
ninja://:blink_wpt_tests/virtual/popover-hint-disabled/external/wpt/html/semantics/popovers/popover-light-dismiss.htmlIf this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5639081310552064&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5402096&type=BUG
Original change's description:
Fix popover-light-dismiss.html
We are failing the last subtest in popover-light-dismiss which clicks
and drags from the main frame to an iframe because chromedriver is
telling chrome that we are doing pointerUp in both the button in the
main frame and the body of the iframe at the same time. I'm not sure
why, but combining the actions sequences and using the main frame's
document as the origin for the pointerUp fixes this.The failure only occurs with run_wpt_tests.py, not run_web_tests.py.
Since writing the above message, another test case was appended which
doesn't include an iframe, and the same fix of using one action sequence
was needed there too, so there must be some chromedriver bug which
doesn't even involve iframes. I verified with internal debug logging
that the new action sequences do in fact exercise the code which needs
to be tested, at least in chromium.Bug: 325981758
Change-Id: I992a01a6baf78a7701da3dd8df76788c93ed0aaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5402096
Reviewed-by: Mason Freed \<masonf@chromium.org>
Commit-Queue: Joey Arhar \<jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1287670}Bug: 325981758
Change-Id: I2abb5b85277bcb5d0801f1f99e198eb5d7c3ea0c
No-Presubmit: true
No-Tree-Checks: true
No-Try: trueReviewed-on: https://chromium-review.googlesource.com/5456057
WPT-Export-Revision: eb2d342a63ef37993e1d8059d2b4d211998b093b
Description
•