1891659 - `HTMLEditor::AutoDeleteRangesHandler::AutoBlockElementsJoiner::DeleteTextAtStartAndEndOfRange()` may delete the text node

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The method does not assume that given range is in a text node. Therefore, it may delete all text in the text node.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1891659 - Make `AutoBlockElementsJoiner::DeleteTextAtStartAndEndOfRange()` handle the case when the range in a text node r=m_kato!

It assumes that the range is always starts and ends in different node. This
is true for now, but this will be called with a text node to delete only
preformatted line break. Note that the only caller of it does not need the
text node(s) if it becomes empty. Therefore, this patch makes it remove the
text node in such case.

Note that the test changed in
input-events-get-target-ranges-deleting-in-list-items.tentative.html was
wrong and only Firefox passed it because the range description was
(#text "", 0) - (#text "", 10) since the text nodes are removed after
deleting the text data of them. Now, they become
(#text "list-item1", 0) - (#text "list-item2", 10).

Depends on D207688

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75ecbad035af
Make `AutoBlockElementsJoiner::DeleteTextAtStartAndEndOfRange()` handle the case when the range in a text node r=m_kato

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45900 for changes under testing/web-platform/tests

Comment 4

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/75ecbad035af

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot