1891699 - dev tools crashes cannot do anything halp

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[fuckdead]

Error:
TypeError: selectedLocation.sourceActor is null

React Component Stack:
in Connect(SourceFooter)
in div
in main
in div
in div
in SplitBox
in div
in div
in SplitBox
in AppErrorBoundary
in div
in App
in Connect(App)
in Provider
in Provider

Stacktrace:
mapStateToProps@resource://devtools/client/debugger/src/components/Editor/Footer.js:339:89
mapToPropsProxy@resource://devtools/client/shared/vendor/react-redux.js:1776:92
handleNewState@resource://devtools/client/shared/vendor/react-redux.js:1937:41
handleSubsequentCalls@resource://devtools/client/shared/vendor/react-redux.js:1954:30
pureFinalPropsSelector@resource://devtools/client/shared/vendor/react-redux.js:1959:32
runComponentSelector@resource://devtools/client/shared/vendor/react-redux.js:1233:39
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1406:23
notify@resource://devtools/client/shared/vendor/react-redux.js:1159:21
notifyNestedSubs@resource://devtools/client/shared/vendor/react-redux.js:1198:20
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1409:16
dispatch@resource://devtools/client/shared/vendor/redux.js:265:7
waitUntilService/</<@resource://devtools/client/debugger/src/actions/utils/middleware/wait-service.js:71:24
promiseMiddleware/</<@resource://devtools/client/debugger/src/actions/utils/middleware/promise.js:38:14
context/</<@resource://devtools/client/debugger/src/actions/utils/middleware/context.js:84:12
thunk/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29:100
dispatch@resource://devtools/client/shared/vendor/redux.js:681:28
setBreakableLines/<@resource://devtools/client/debugger/src/actions/sources/breakableLines.js:62:15

Comment 1

[Julian Descottes [:jdescottes] (PTO 20 oct -> 25 oct)]

Can you share which version of Firefox you are using? In the file mentioned in the stacktrace, we are checking that selectedLocation.sourceActor is defined before accessing it so it might be fixed in the latest Firefox versions.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

we're not guarding here: https://searchfox.org/mozilla-central/rev/b94e479d0b79b157029379832d05229df646e134/devtools/client/debugger/src/components/Editor/Footer.js#417

selectedLocation?.sourceActor.id

if sourceActor is null, this throws

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1891699 - [devtools] Remove unused sourceMapURL React component property.

This could possibly throw if sourceActor was null, and wasn't used.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9cb15fbf3387
[devtools] Remove unused sourceMapURL React component property. r=devtools-reviewers,nchevobbe

Comment 5

[Julian Descottes [:jdescottes] (PTO 20 oct -> 25 oct)]

Indeed, I missed this when checking the component this morning!

Comment 6

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/9cb15fbf3387