1891743 - [wpt-sync] Sync PR 45739 - [PEPC] Provide partial padding support to allow for common use case

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45739 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45739
Details from upstream follow.

Andy Paicu <[e-mail]> wrote:

[PEPC] Provide partial padding support to allow for common use case

Removal of 'padding' support from the permission element has removed
support for a common use case that used padding in conjuction with
'width: auto'. Since it is very difficult to provide a fixed width
for the permission element (as the text can change and is not under
the control of the site author), this CL provides a mechanism that
sets the width/height based on padding.

We don't want to simply support padding unchecked since it can be
used to push the text outside of the permission element area, and
creating a bounded expression is very difficult because 'calc-size'
is not supported for padding lengths.

Bug: 1462930
Change-Id: I19e6f9ff6fcd11073b1da0efaa68f743ea3886bb
Reviewed-on: https://chromium-review.googlesource.com/5458152
WPT-Export-Revision: f5ab213d807b90f988b211f12d92fb9a7ea3e3d1

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 45739 applied with additional changes from upstream: 7c2a090d60996315c82651c562aaea988d2220b5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8f7d3d947ef8e4d1ac3f9d151efba007b5726ff

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c32d59aa9246bd2137321b0c942cae18407e2e2

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

OK : 1
FAIL: 3

Chrome

OK : 1
FAIL: 3

Safari

OK : 1
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/permission-element/bounded-sizes.tentative.html [wpt.fyi]
  • Properties with out-of-bounds values should be corrected: FAIL (Chrome: FAIL, Safari: FAIL)
  • Properties with values in bounds should not be modified: FAIL (Chrome: FAIL, Safari: FAIL)
• /html/semantics/permission-element/bounded-sizes-reftest.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/baee9d4abcc8
[wpt PR 45739] - [PEPC] Provide partial padding support to allow for common use case, a=testonly
https://hg.mozilla.org/integration/autoland/rev/21e09b445917
[wpt PR 45739] - Update wpt metadata, a=testonly

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/baee9d4abcc8
https://hg.mozilla.org/mozilla-central/rev/21e09b445917