ShortURL.sys.mjs splits off the effective TLD before converting to display IDN
Categories
(Firefox :: New Tab Page, defect)
Tracking
()
People
(Reporter: hsivonen, Unassigned, NeedInfo)
References
Details
https://searchfox.org/mozilla-central/rev/77f8c66362e5f18f8e7cbaf1ba3ed6286f203d33/browser/components/newtab/lib/ShortURL.sys.mjs#84 performs IDN handling after spitting off the effective TLD.
Our display IDN handling is now sensitive to the TLD (e.g. on .cat and .is), so this code gets wrong results by hiding the TLD from the display IDN conversion.
The display IDN conversion should happen before splitting off the effective TLD. (Since it appears that the effective TLD code wants the ASCII form, perhaps the splitting code needs to count how many labels to split off given that the labels may change from the ASCII form to the Unicode form. Maybe we should even have a bundled C++-side operation for taking a domain, converting it to display form, and returning it split into two parts: the part before the effective TLD and the effective TLD.)
|
||
Comment 1•1 year ago
|
||
The severity field is not set for this bug.
:amy, could you have a look please?
For more information, please visit BugBot documentation.
Description
•