1891783 - Fix two more bugs in ShadowDOM Selection

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Sean Feng [:sefeng]]

Attachment: Bug 1891783 - Fix two more bugs in ShadowDOM Selection

Bug #1: AbstractRange::(Mark|Unmark)Descendants should always use
the shadow tree of web-exposed shadow root, instead of using
light DOM elements of the host.

Bug #2: aRange could possibly create mCrossShadowBoundaryRange
first (due to boundaries are in different tree), and later
moves the boundaries to the same tree. When this happens, we
should remove mCrossShadowBoundaryRange and use the default
range to represent it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/515d309fa973
Fix two more bugs in ShadowDOM Selection r=jjaschke,smaug,dom-core

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46139 for changes under testing/web-platform/tests

Comment 4

[Cristian Tuns]

Backed out for causing wpt failures in /shadow-dom/*

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | /shadow-dom/focus/focus-pseudo-on-shadow-host-2.html | assertion count 2 is more than expected 0 assertions

Failure line 2:TEST-UNEXPECTED-FAIL | /shadow-dom/focus-navigation/reading-order/tentative/grid-order-with-slots.html | assertion count 34 is more than expected 0 assertions

Log 2: https://treeherder.mozilla.org/logviewer?job_id=457291682&repo=autoland

Comment 5

[Sean Feng [:sefeng]]

ah I forgot I need to land the patch along with D208370, sorry about that

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 7

[Sean Feng [:sefeng]]

Attachment: Bug 1891783 - Ensure a consistent behaviour for slotted contents r=#dom-core,jjaschke,smaug!

This patch ensures we always use the Shadow-including order for
selecting nodes.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f54a84c32d1
Fix two more bugs in ShadowDOM Selection r=jjaschke,smaug,dom-core
https://hg.mozilla.org/integration/autoland/rev/6fc61adc95d0
Ensure a consistent behaviour for slotted contents r=smaug

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0f54a84c32d1
https://hg.mozilla.org/mozilla-central/rev/6fc61adc95d0

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot