Fix two more bugs in ShadowDOM Selection
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox128 | --- | fixed |
People
(Reporter: sefeng, Assigned: sefeng)
References
Details
Attachments
(2 files)
Assignee | ||
Comment 1•2 months ago
|
||
Bug #1: AbstractRange::(Mark|Unmark)Descendants should always use
the shadow tree of web-exposed shadow root, instead of using
light DOM elements of the host.
Bug #2: aRange could possibly create mCrossShadowBoundaryRange
first (due to boundaries are in different tree), and later
moves the boundaries to the same tree. When this happens, we
should remove mCrossShadowBoundaryRange and use the default
range to represent it.
Updated•2 months ago
|
Pushed by sefeng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/515d309fa973 Fix two more bugs in ShadowDOM Selection r=jjaschke,smaug,dom-core
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46139 for changes under testing/web-platform/tests
Comment 4•2 months ago
•
|
||
Backed out for causing wpt failures in /shadow-dom/*
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | /shadow-dom/focus/focus-pseudo-on-shadow-host-2.html | assertion count 2 is more than expected 0 assertions
Failure line 2:TEST-UNEXPECTED-FAIL | /shadow-dom/focus-navigation/reading-order/tentative/grid-order-with-slots.html | assertion count 34 is more than expected 0 assertions
Log 2: https://treeherder.mozilla.org/logviewer?job_id=457291682&repo=autoland
Assignee | ||
Comment 5•2 months ago
|
||
ah I forgot I need to land the patch along with D208370, sorry about that
Upstream PR was closed without merging
Assignee | ||
Comment 7•2 months ago
|
||
This patch ensures we always use the Shadow-including order for
selecting nodes.
Pushed by sefeng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f54a84c32d1 Fix two more bugs in ShadowDOM Selection r=jjaschke,smaug,dom-core https://hg.mozilla.org/integration/autoland/rev/6fc61adc95d0 Ensure a consistent behaviour for slotted contents r=smaug
Comment 9•2 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0f54a84c32d1
https://hg.mozilla.org/mozilla-central/rev/6fc61adc95d0
Upstream PR merged by moz-wptsync-bot
Description
•