1891788 - Local dumps from production can replace downloads from stage

Status: RESOLVED FIXED

(Firefox :: Remote Settings Client, defect)

Description

[Mark Banner (:standard8)]

Sometimes dumps can replace the staging data - for instance, if staging is older than the dump, then the newer timestamp of the dump will take priority over that of the staging data.

This isn't an issue a lot of the time, but for attachments it means that we try and load the attachment data with the production ids from the staging server, which isn't going to work.

STR

1. Set up a Firefox nightly build, with remote settings devtools.
2. Ensure that the search-config-icons collection on stage is older than that of production.
3. Set the preference services.settings.loglevel to all and restart.
4. Open the devtools interface and choose to clear local data on main-preview/search-config-icons
5. Restart Nightly, and open the browser console.
6. Search the browser console for search-config-icons. At this stage, you'll find messages like:

services.settings: Instantiated new client main-preview/search-config-icons
services.settings: main-preview/search-config-icons Local DB is empty, pull data from server
services.settings: main-preview/search-config-icons Fetch changes from server (expected=1707263524486, since=undefined)
services.settings: main-preview/search-config-icons local timestamp: null, remote: 1707263524486
 services.settings: main-preview/search-config-icons 0 to delete, 43 to insert

7. Restart nightly again.
8. Search the browser console again.

Actual Results

services.settings: Instantiated new client main-preview/search-config-icons
services.settings: main-preview/search-config-icons Local DB is stale (1707263524486), using dump instead (1707330724491)
services.settings: main-preview/search-config-icons try to restore dump
services.settings: main-preview/search-config-icons imported 43 records from dump

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1891788 - Don't load the remote settings dump when it is newer if we are not on production. r?leplatrem!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1891788 - Create a head file for services/settings/test/unit/. r?leplatrem!

Also switch tests to add_setup.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba874af8581d
Create a head file for services/settings/test/unit/. r=leplatrem
https://hg.mozilla.org/integration/autoland/rev/650dda918743
Don't load the remote settings dump when it is newer if we are not on production. r=leplatrem

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ba874af8581d
https://hg.mozilla.org/mozilla-central/rev/650dda918743