1891799 - Update search-telemetry-v2 schema as part of Google account signed-in status work

Status: RESOLVED FIXED

(Firefox :: Search, task, P1)

Description

[Stephanie Cunnane [:scunnane]]

We'll need to add the parameter accountCookies to search-telemetry-schema in conjunction with our work to determine whether a client is signed in to a Google account at the time of SERP load.

Comment 1

[Stephanie Cunnane [:scunnane]]

Attachment: Bug 1891799 - Update search-telemetry-v2 schema as part of Google account signed-in status work. r?jteow!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:scunnane, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Stephanie Cunnane [:scunnane]]

This RS schema update will now take place alongside bug 1892224, which I will work on soon.

Comment 4

[Stephanie Cunnane [:scunnane]]

Note: code that I landed in Firefox 127 introduced a new parameter accountCookies to search-telemetry-v2-schema in conjunction with our work to determine whether a client is signed in to a Google account at the time of SERP load. Because QA found an issue related to PBM, I did held off on the corresponding RS update. Then in bug 1892332, which I landed in Firefox 128, I added code that fixes the PBM issue QA found.

Since the original work is in 127 and the fix is in 128, I've opted to rename the parameter from accountCookies to signedInCookies so that clients on 127 don't encounter the original (now fixed) issue. (The other alternative would have been to leave the accountCookies parameter as is and uplift my PBM fix and one of James's patches that my fix depends on. Since there isn't a deadline that would require uplifting, I think changing the parameter name is more straightforward than an uplift, though yes, a tiny bit hacky.)

Comment 5

[Stephanie Cunnane [:scunnane]]

The RS schema has now been updated (see bug 1900687).

Comment 6

[Stephanie Cunnane [:scunnane]]

Re-opening this to land it, as I had mistakenly assumed schema updates were synched to mozilla-central (similar to RS dumps).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/892028ffc927
Update search-telemetry-v2 schema as part of Google account signed-in status work. r=jteow

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/892028ffc927