1891816 - Refactor gOnceInitializedDeferred to use Promise.withResolvers

Status: RESOLVED FIXED

(Firefox :: Session Restore, task, P5)

Description

[Sam Foster [:sfoster] (he/him)]

This is just a little code cleanup. gOnceInitializedDeferred was written before Promises got withResolvers as a standardized "deferred" solution. Per MDN, calling gOnceInitializedDeferred = Promise.withResolvers() should be directly equivalent to the custom deferred implementation used currently.

Comment 1

[Sam Foster [:sfoster] (he/him)]

If you are interested in working on this, please leave a note here and check the "need info" box to notify me of your interest. You should prepare an initial patch and submit it to phabricator for review. Your patch just needs to make the indicated changes in SessionStartup.sys.mjs - there's no need for new tests or anything like that. We'll just need to make sure existing tests pass before landing the change.

Comment 2

[endington543]

Hi :) I'm a new contributor and would like to contribute to this issue.

Comment 3

[Sam Foster [:sfoster] (he/him)]

(In reply to endington543 from comment #2)

Hi :) I'm a new contributor and would like to contribute to this issue.

Thanks for taking an interest. Go ahead and put together a patch and push it to phabricator for review. The tools and process to follow are all pretty well documented. For this ptach you only need a artifact build, you don't need all the dependencies and toolchain for building our c++ and rust code.. If you have questions getting set up, you can get help in the #introduction channel in matrix.

Comment 4

[endington543]

Attachment: Bug 1891816 - Refactor gOnceInitializedDeferred to use Promise.withResolvers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37aaa704c1d0
Refactor gOnceInitializedDeferred to use Promise.withResolvers r=sessionstore-reviewers,sfoster

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/37aaa704c1d0