Refactor gOnceInitializedDeferred to use Promise.withResolvers
Categories
(Firefox :: Session Restore, task, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox127 | --- | fixed |
People
(Reporter: sfoster, Assigned: danielmazarakos, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=js] [fidefe-session-restore] )
Attachments
(1 file)
This is just a little code cleanup. gOnceInitializedDeferred was written before Promises got withResolvers as a standardized "deferred" solution. Per MDN, calling gOnceInitializedDeferred = Promise.withResolvers() should be directly equivalent to the custom deferred implementation used currently.
|
||
Updated•2 months ago
|
|
Reporter | |
Comment 1•2 months ago
|
||
If you are interested in working on this, please leave a note here and check the "need info" box to notify me of your interest. You should prepare an initial patch and submit it to phabricator for review. Your patch just needs to make the indicated changes in SessionStartup.sys.mjs - there's no need for new tests or anything like that. We'll just need to make sure existing tests pass before landing the change.
|
Assignee | |
Comment 2•1 month ago
|
||
Hi :) I'm a new contributor and would like to contribute to this issue.
|
|
Reporter | |
Comment 3•1 month ago
|
||
(In reply to endington543 from comment #2)
Hi :) I'm a new contributor and would like to contribute to this issue.
Thanks for taking an interest. Go ahead and put together a patch and push it to phabricator for review. The tools and process to follow are all pretty well documented. For this ptach you only need a artifact build, you don't need all the dependencies and toolchain for building our c++ and rust code.. If you have questions getting set up, you can get help in the #introduction channel in matrix.
|
|
Assignee | |
Comment 4•1 month ago
|
||
|
||
Updated•1 month ago
|
|
|
||
Updated•1 month ago
|
|
|
Assignee | |
Updated•1 month ago
|
|
|
||
Updated•1 month ago
|
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/37aaa704c1d0 Refactor gOnceInitializedDeferred to use Promise.withResolvers r=sessionstore-reviewers,sfoster
|
||
Comment 6•1 month ago
|
||
| bugherder | ||
Description
•