1891820 - [wpt-sync] Sync PR 45745 - Reland "[css-anchor-position] Fix scroll adjustment when the anchor is scrollable"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45745 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45745
Details from upstream follow.

Xianzhu Wang <[e-mail]> wrote:

Reland "[css-anchor-position] Fix scroll adjustment when the anchor is scrollable"

This reverts commit f1ecb1a8a0b0d6ff670622e9bdb49bd938d3e942.

Reason for revert: Fixed compilation error caused by conflicting CL
landed earlier.

Original change's description:

Revert "[css-anchor-position] Fix scroll adjustment when the anchor is scrollable"

This reverts commit 7f62e03dd59125d710ed279afdb793b6df429441.

Reason for revert: Broke builders, see https://ci.chromium.org/ui/p/chromium/builders/ci/lacros-arm-archive-rel/93790/overview

Original change's description:

[css-anchor-position] Fix scroll adjustment when the anchor is scrollable

Previously the scroll offset of the anchor itself was included in the
accumulated adjustment.

Bug: 40059176
Change-Id: Idb7d2f87b1ae137cab1e7396218f26a5b47d7014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5456116
Reviewed-by: Philip Rogers \<[e-mail]>
Commit-Queue: Xianzhu Wang \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1288191}

Bug: 40059176
Change-Id: Ic7fe44f8875e2dbfd4879c06aa4aaa3c6e31d958
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5459880
Owners-Override: Dominique Fauteux-Chapleau \<[e-mail]>
Auto-Submit: Dominique Fauteux-Chapleau \<[e-mail]>
Commit-Queue: Rubber Stamper \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1288201}

Bug: 40059176
Change-Id: If6ecb510445d991a4505dbb036d162c22bfd113f

Reviewed-on: https://chromium-review.googlesource.com/5458902
WPT-Export-Revision: c4c8fed8147b33e756507052127a6530fa579d8b

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe0b3cc68a9b989a4c27c7c44ba82605192dcb22

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

PASS: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-anchor-position/anchor-scroll-scrollable-anchor.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3c32a467018
[wpt PR 45745] - Reland "[css-anchor-position] Fix scroll adjustment when the anchor is scrollable", a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e3c32a467018