1891854 - Do not copy session store cookies in the backup staging directory if the backup is not encrypted

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[kpatenio]

For some BackupResources, we may only want to copy certain bits of data if the backup file is not encrypted. For instance, we don't want to store cookies in the staging directory for the session store backup resources. We could update the backup methods for each BackupResource to pass information about the encryption state to do this.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1891854 - Do not backup session cookies if backup encryption is not enabled. r?#backup-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8773eda97c1
Do not backup session cookies if backup encryption is not enabled. r=backup-reviewers,fchasen

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures @ test_BackupService_renderTemplate.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/ba3427ddddb6b457ba8ab233bc0e6506aa9bc350

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/backup/tests/xpcshell/test_BackupService_renderTemplate.js | xpcshell return code: 1

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e149edafb1b
Do not backup session cookies if backup encryption is not enabled. r=backup-reviewers,fchasen

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/7e149edafb1b