1891867 - Crash in [@ java.lang.IndexOutOfBoundsException: at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java)] from org.mozilla.fenix.onboarding.view.OnboardingScreenKt$OnboardingScreen

Status: RESOLVED FIXED

(Firefox for Android :: Onboarding, defect)

Description

[Chris Peterson [:cpeterson]]

Crash report: https://crash-stats.mozilla.org/report/index/471d2715-d122-4c30-b157-2cb530240416

This is not a new crash signature, but it looks like there might have been a regression in Fx 123 (2024-02-20) that increased the crash volume. Looks like all the crashes are from Android versions >= 12 (API 31).

Exception: java.lang.IndexOutOfBoundsException
Message: Index 1 out of bounds for length 1

Top 10 frames:

0  jdk.internal.util.Preconditions  outOfBounds  Preconditions.java:64
1  jdk.internal.util.Preconditions  outOfBoundsCheckIndex  Preconditions.java:70
2  jdk.internal.util.Preconditions  checkIndex  Preconditions.java:266
3  java.util.Objects  checkIndex  Objects.java:359
4  java.util.ArrayList  get  ArrayList.java:434
5  org.mozilla.fenix.onboarding.view.OnboardingScreenKt$OnboardingScreen$3$2  emit  OnboardingScreen.kt:9
6  kotlinx.coroutines.flow.internal.SafeCollectorKt$emitFun$1  invoke  SafeCollector.kt:5
7  kotlinx.coroutines.flow.internal.SafeCollector  emit  SafeCollector.kt:17
8  kotlinx.coroutines.flow.internal.SafeCollector  emit  SafeCollector.kt:1
9  androidx.compose.runtime.SnapshotStateKt__SnapshotFlowKt$snapshotFlow$1  invokeSuspend  SnapshotFlow.kt:184

Comment 1

[Chris Peterson [:cpeterson]]

Roger, could your fix for "Hide default browser onboarding card" bug 1874768 have caused this crash? Bug 1874768 is the only bug in the Fenix::Onboarding component that shipped in Fx 123. These crash reports for IndexOutOfBoundsExceptions from org.mozilla.fenix.onboarding.view.OnboardingScreenKt$OnboardingScreen are not new, but we saw an increase starting in Fx 123.

Comment 2

[[:harrisono]]

Attachment: Bug 1891867 - Fix index call in scrollToNextPageOrDismiss in OnboardingScreen

Comment 3

[[:harrisono]]

Landing prospective fix to Nightly to soak for the weekend before we uplift to Beta to see if it brings down this crash rate.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f87fa022d3d
Fix index call in scrollToNextPageOrDismiss in OnboardingScreen r=android-reviewers,Roger

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1f87fa022d3d

Comment 6

[Donal Meehan [:dmeehan]]

:harrisono adding a reminder about Comment 4 when you get a moment.
We are in the final week of beta for Fx126 and will only have 2 beta builds left.

Comment 7

[[:harrisono]]

I think this is safe to uplift to beta. I'll make a beta uplift request now.

Comment 8

[[:harrisono]]

Comment on attachment 9398449 [details]
Bug 1891867 - Fix index call in scrollToNextPageOrDismiss in OnboardingScreen

Beta/Release Uplift Approval Request

• User impact if declined: Potential fix for onboarding card crash will wait for another beta cycle before being released to users.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky, has not created crashes in Nightly and is a small logic change to prevent out of index errors.
• String changes made/needed:
• Is Android affected?: No

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9398449 [details]
Bug 1891867 - Fix index call in scrollToNextPageOrDismiss in OnboardingScreen

Approved for 126.0b8

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2c0a49082699

Comment 11

[[:harrisono]]

might be too early to celebrate but I am not seeing any crash signatures matching this crash in Beta 126.0b8 or later.

https://crash-stats.mozilla.org/search/?release_channel=beta&signature=%3Djava.lang.IndexOutOfBoundsException%3A%20at%20jdk.internal.util.Preconditions.outOfBounds%28Preconditions.java%29&product=Fenix&date=%3E%3D2024-04-14T00%3A00%3A00.000Z&date=%3C2024-05-06T15%3A14%3A00.000Z&_facets=install_time&_facets=version&_facets=address&_facets=moz_crash_reason&_facets=reason&_facets=build_id&_facets=platform_pretty_version&_facets=signature&_facets=useragent_locale&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports