1891926 - "Use system Web Proxy Auto-Discovery setting" checkbox is not shown even if "network.proxy.system_wpad.allowed" is set to true

Status: VERIFIED FIXED

(Core :: Networking: Proxy, defect)

Description

[Masatoshi Kimura [:emk]]

Steps to reproduce:

1. Open about:config.
2. Flip network.proxy.system_wpad.allowed to true.
3. Go to humberger menu > Settings > General > Network Settings.
4. Click Settings... button.

Actual result:
"Use system Web Proxy Auto-Discovery setting" checkbox is not shown below "Use system proxy settings" radio item.

Expected result:
"Use system Web Proxy Auto-Discovery setting" checkbox should be shown.

Current workaround is flipping network.proxy.system_wpad directly from about:config instead of using Settings page.

You forgot to add { id: "network.proxy.system_wpad.allowed", type: "bool" }, here.

Comment 1

[Masatoshi Kimura [:emk]]

Moreover, you refers a Preference object itself instead of its value here. The Preferences.get call will return null until { id: "network.proxy.system_wpad.allowed", type: "bool" }, is added and it will return an object after the addition. The check does not work correctly in either case.

Did you even test the build?

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Bug 1891926 - Make "network.proxy.system_wpad.allowed" actually work. r?kershaw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d61facc725b
Make "network.proxy.system_wpad.allowed" actually work. r=settings-reviewers,Gijs

Comment 4

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/6d61facc725b

Comment 5

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to replicate the issue on an affected Firefox Nightly 126.0a1 build, from 2024-04-07, using Windows 11, by following the steps mentioned in Comment 0.
Verified on Firefox 127.0b9, build ID 20240531105723, using Windows 11, Ubuntu 22.04 and macOS 14.4. "Use system Web Proxy Auto-Discovery setting" checkbox is now shown on Windows 11, but not on Ubuntu 22.04 and macOS 14.4.
@emk, is this Windows specific or should we reopen the bug? Thank you in advance!

Comment 6

[Masatoshi Kimura [:emk]]

This is Windows specific. See https://phabricator.services.mozilla.com/D203387.

Comment 7

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Thank you for the confirmation!
Based on Comment 5, I am marking this verified as fixed.