1891954 - Intermittent browser/components/extensions/test/browser/browser_ext_menus_targetElement.js | targetElementId from different tab should not resolve. - Expected: null, Actual: [object HTMLParagraphElement]

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: rob [at] robwu.nl
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=454798990&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/NXUjhtIFTACSTvevzZ8WRg/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Rob Wu [:robwu]]

All recently reported failures in bug 1775562 are associated with the following error:

TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_menus_targetElement.js | targetElementId from different tab should not resolve. - Expected: null, Actual: [object HTMLParagraphElement] -

The failure comes from https://searchfox.org/mozilla-central/rev/b94e479d0b79b157029379832d05229df646e134/browser/components/extensions/test/browser/browser_ext_menus_targetElement.js#305,310-316

A potential way for this to happen is if targetElementId === targetElementId2, which would be unlucky but not theoretically impossible. I'll submit a patch to retry getting a new ID when this unlucky situation happens.

Comment 2

[Rob Wu [:robwu]]

Attachment: Bug 1891954 - Fix intermittent failure in browser_ext_menus_targetElement.js

Comment 3

[Rob Wu [:robwu]]

I confirmed with --verify (TV) that the proposed patch can catch an instance of an unexpected duplicate tab ID and that it can recover from that failure, as follows:

$ ./mach test browser/components/extensions/test/browser/browser_ext_menus_targetElement.js --log-mach-verbose --headless --verify

...
0:50.59 INFO Got same targetElementId 381, retrying for a new one
0:50.63 PASS targetElementId differ - 381 != 427 -
0:50.64 PASS Expected message - Expected: checkIsValid, Actual: checkIsValid -
0:50.65 PASS targetElementId from different tab should not resolve. - Expected: null, Actual: null -

Before this patch, the output would have been:

TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_menus_targetElement.js | targetElementId from different tab should not resolve. - Expected: null, Actual: [object HTMLParagraphElement] -

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7291074e288
Fix intermittent failure in browser_ext_menus_targetElement.js r=willdurand

Comment 5

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/d7291074e288

Comment 6

[Intermittent Failures Robot]

1 failures in 4252 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform and build breakdown:

• windows11-64-2009-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1891954&startday=2024-04-15&endday=2024-04-21&tree=all