1891977 - close icon regression: incorrect location in the titlebar on Linux; themed variants also have odd styling

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Garrett LeSage]

Attachment: firefox-issues-titlebar.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:125.0) Gecko/20100101 Firefox/125.0

Steps to reproduce:

Opened Firefox, looked at the titlebar.

Actual results:

The close button is not properly positioned, and in anything other than the default theme, has major issues including accessibility.

Expected results:

The titlebar should look correct and match all other windows with horizontal positioning, as it had before. And it should be possible to see the icons with custom themes while hovering.

It was never really superb, but it got worse in this most recent release (125).

Comment 1

[Garrett LeSage]

Attachment: comparison with GNOME Adwaita titlebars

Here's a comparison of what it should look like these days (GNOME has looked like this for the past couple years), with both visuals and spacing. The leftmost top two are Firefox with CSD, unhovered (default) above, and hovered the second down. Below and to the right are all GNOME titlebars for comparison.

Comment 2

[Garrett LeSage]

Attachment: comparison with GNOME old style titlebars

Similar to the previous screenshot crops, this is a comparison with the old style of GNOME, which is what Firefox is trying to mimic. It's still quite a bit off.

As there is more vertical space around the button, there needs to be more horizontal space between the button and the rightmost edge of the window too, to be visually balanced. As you can see, Firefox not only does not have more space — it actually has less (by a pixel).

Comment 3

[Garrett LeSage]

Attachment: comparison with Nautilus from GNOME 46

What's interesting is that GNOME Files (aka: Nautilus) has almost the same spacing as Firefox for the vertical height. It's an app with CSD window borders (versus the fallback ones I compared it to in the other screenshots). GNOME Files actually has 2 more pixels (1 above and 1 below), so it actually should serve as a good reference for where the close button should go.

This is basically how Firefox should look on Linux with regard to visuals and positioning, in other words. The grid lines from the sides and below show how far Firefox is off. (It's quite a bit.)

Comment 4

[Emilio Cobos Álvarez (:emilio)]

This is a regression from bug 1560702. See bug 1560702 comment 22 in particular about the context for the spacing change.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

The dark / custom theme issue I can't reproduce, in nightly nor release, do you have any custom css that could affect that?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1891977 - Improve titlebar button spacing on Linux. r=stransky,#theme

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1891977 - Slightly less outrageous approach. r=stransky,#theme

Account for button margins in our spacing computations. This doesn't
exactly match what gtk does (but we can't always match what gtk does
easily anyways), and is not so ridiculously complicated as the previous
approach.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3dc13e07cf0b
Slightly less outrageous approach. r=stransky

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3dc13e07cf0b

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox126 to wontfix.

For more information, please visit BugBot documentation.