1892007 - Make sure BackupService runs PlacesBackupResource's `backup` method first

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

From local testing, the PlacesBackupResource::backup method is the one likely to run the longest, especially for older profiles. This is because the places.sqlite database is likely quite large, and write operations to that database (which occur during most navigations) will delay the backup from completing.

Since we're confident that this one is the "long pole", I propose that we run its backup method first. The others can run in any order, as they're all fairly quick. This way, we won't run into a situation where SOME of a user's information is a backup created many minutes in the past vs the PlacesBackupResource.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

fchasen brought up a good point that since the favicons.sqlite and places.sqlite databases are so closely intertwined (in fact, they're attached), we might also want to run the SQLite online backup process on them concurrently.

Comment 2

[Fred Chasen [:fchasen]]

Attachment: Bug 1892007 - Add optional priority number to BackupResource. r?#backup-reviewers!

• Adds a static backupPosition getter in BackupResource base class, which defaults to 0.
• Determine the order resources will be backed up based on that position in createBackup, defaulting to unordered.
• Sets PlacesBackupResource position 1 so it will run first.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26c19d7e3c85
Add optional priority number to BackupResource. r=backup-reviewers,mconley

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/26c19d7e3c85