1892097 - TimingDistributionMetric would benefit from a single-duration API

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Chris H-C :chutten|PTO (back Jan 5)]

bug 1881297 introduced a single-sample API to CustomDistributionMetric and TimingDistributionMetric. Unfortunately, FOG can't use the latter one, since it doesn't know how to translate from a duration to a sample (it doesn't keep the TimeUnit around).

Maybe we should consider a accumulate_raw_duration API that takes a std::time::Duration? Or a accumulate_raw_single_sample_nanos for a u64's worth of nanos?

...and maybe we reconsider exposing accumulate_single_sample since bindings won't necessarily be able to make the duration-to-sample conversion themselves.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/glean] bug 1892097 - New TimingDistribution API for a single duration. (#2809)

Comment 2

[Chris H-C :chutten|PTO (back Jan 5)]

chutten merged PR [mozilla/glean]: bug 1892097 - New TimingDistribution API for a single duration. (#2809) in 173201d.