1892177 - Need zeroing overscroll vector components where overscrolling should not happen on axis

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

Before sending overscroll offsets to GeckoView, we need to something similar to what we do on desktops.

Comment 1

[Botond Ballo [:botond]]

For some context, this was split out from bug 1892102, for the "overscrolling horizontally" part. Steps to reproduce can be found there.

Comment 2

[Dan Robertson (:dlrobertson)]

I think this would be a good first issue for someone looking to get started contributing to Gecko. If someone is looking to pick this up, please leave a comment, and we can provide some good next steps.

Comment 3

[Adam Motaouakkil]

Hi! I'm looking to start contributing, particularly with graphics. I'd like to give this bug a shot :)

Comment 4

[Dan Robertson (:dlrobertson)]

That's great to hear Adam!

The first step should be getting a locally built firefox that you can run an test.

If you have not worked on a patch for firefox before, you might check out the firefox contributors quickref here.

Note that if bootstrap is run, make sure to avoid selecting an option for a "artifact" build.

Once you have a locally built firefox that can be run with ./mach run, reach out again and I can provide next steps.

Feel free to comment here or join mozilla matrix to reach out with quesitons. If you join the matrix instance panning and zooming tend to take place in the APZ channel

Comment 5

[Adam Motaouakkil]

Attachment: Bug 1892177 - Reset overscroll offset in directions where no scrolling should occur. r=hiro,botond

Comment 6

[Adam Motaouakkil]

Just submitted a patch for the bug. I am using the android emulator to test the changes and here are the steps I followed:

• Go to some webpage, I used wikipedia.
• Scroll up and down by clicking on the screen and dragging up and down, simulating touchscreen. Scrolling past the top of a webpage only produced the animation on the screen that indicates that you've reached the limit of the webpage (that lightly shaded half circle that appears and disappears).
• I tried dragging left and right, but there was no stretching, no animation indicating I had reached the limit of a webpage, just unable to drag past the bounds.
• Following the code I wrote, I rebuilt and tested it and found that I could stretch the webpage vertically up and down. However, the webpage would not go back to its original position, it just stayed stretched. I don't know if that's the emulator that can't exactly translate mouse input to the touchscreen input, but that's what I observed.

Comment 7

[Adam Motaouakkil]

Attachment: Bug 1892177 - Add unit test for the stretching of a web page scrolling up or down r=dlrobertson

Comment 8

[Frank Griffith Jr]

Dan, are these patches ready for your review? Just checking on these as we wrap up the half?

Comment 9

[Dan Robertson (:dlrobertson)]

This work is being tackled by a volunteer contributor. It might make sense to move this to the next half.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 11

[Adam Motaouakkil]

I fixed my emulator issue, reinstalling a fair amount of things made things go away.

Comment 12

[Adam Motaouakkil]

(In reply to Adam Motaouakkil from comment #11)

I fixed my emulator issue, reinstalling a fair amount of things made things go away.

Meaning I am ready to get back on this :)

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/77024a9cb31b
https://hg.mozilla.org/integration/autoland/rev/a6da45c15026
Reset overscroll offset in directions where no scrolling should occur. r=botond,hiro

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a6da45c15026