1892187 - [Windows] Drop-down menu from Sidebar panel does not collapse on second click

Status: NEW

(Firefox :: Menus, defect, P5)

Description

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: drop-down still expanded

Found in

• Latest Nightly 127.0a1 (2024-04-17)

Affected versions

• 127.0a1
• 126.0b2
• 125.0.1

Tested platforms

• Affected platforms: Windows 11
• Unaffected platforms: macOS 12.6.6, Ubuntu 22.04

Preconditions

• Have the Sidebar panel added to the browser toolbar

Steps to reproduce

1. Open the Sidebar panel (if not already open) and click the “Bookmarks” drop-down
2. Click again the “Bookmarks” drop-down and observe the behavior

Expected result

• The drop-down menu is collapsed

Actual result

• The drop-down menu is still expanded (disappears for a brief second and then reappears)

Regression range

• Last good build: 2023-06-14
• First bad build: 2023-06-15
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ecab7f04e7d616a69e1d213ac8e660ebae99926d&tochange=214490a419fb2f60b4ea03f3bf17c3f0d5bb4d09
• Potentially regressed by: Bug 1835890

Additional notes

• See the attached video
• Reproducing for the “History” / “Sync tabs” options from the drop-down menu as well
• Steps 1 and 2 need to be repeated several times in order for the issue to reproduce on older builds

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:dao, since you are the author of the regressor, bug 1835890, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Dão Gottwald [:dao]]

Probably not worth fixing this given the new sidebar work.

Comment 3

[Sarah Clements [:sclements]]

I expect we'll need to keep the legacy sidebar working for the control branch of any experiments we run though.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Sarah Clements [:sclements] from comment #3)

I expect we'll need to keep the legacy sidebar working for the control branch of any experiments we run though.

That's fine, but I still don't think this means we should spend time on this minor bug. Let me know if you disagree.