1892223 - Enable ECDH encryption and decryption for S/MIME

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, enhancement)

Description

[Kai Engert [:KaiE:]]

Now that ECDH support for S/MIME has been added to NSS, and the corresponding version of NSS has been made available in mozilla-central (bug 1891763), we're ready to enable that encryption mode in Thunderbird.

We can do that as suggested in the code from bug 1876931, by using the recently added NSS API NSS_CMSRecipient_IsSupported().

Comment 1

[Kai Engert [:KaiE:]]

I see build/moz.configure/nss.configure already requires 3.99 which contains NSS_CMSRecipient_IsSupported

Comment 2

[Kai Engert [:KaiE:]]

ECDH is enabled in NSS_CMSRecipient_IsSupported version 3.100 which has already been landed into m-c

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Bug 1892223 - Enable ECDH encryption as covered by NSS_CMSRecipient_IsSupported from NSS version 3.100. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7e83e0b67b38
Enable ECDH encryption as covered by NSS_CMSRecipient_IsSupported from NSS version 3.100. r=mkmelin

Comment 5

[Geoff Lankow (:darktrojan)]

This patch doesn't build on macOS or Windows, so I backed it out.
https://hg.mozilla.org/comm-central/rev/ff9bed5002f566f0ee17eddeae81e4bb6a83628b

Comment 6

[Kai Engert [:KaiE:]]

(In reply to Geoff Lankow (:darktrojan) from comment #5)

This patch doesn't build on macOS or Windows, so I backed it out.
https://hg.mozilla.org/comm-central/rev/ff9bed5002f566f0ee17eddeae81e4bb6a83628b

Sorry, too much self-confidence from my side on an apparent trivial change.

I've fixed the patch, we needed to add the new symbol to a build file.
It passed try:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=baaaaed5e6cc40835991f4ffc7036094900b0210

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f7fcde19f287
Enable ECDH encryption as covered by NSS_CMSRecipient_IsSupported from NSS version 3.100. r=mkmelin