New wpt failures in /shadow-dom/focus-navigation/ [delegatesFocus-highlight-sibling.html, focus-navigation-slot-fallback-default-tabindex.html, focus-navigation-slot-fallback.html, and 15 others]
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
People
(Reporter: wpt-sync, Unassigned)
References
Details
(Whiteboard: [wpt])
Syncing wpt PR 45772 found new untriaged test failures in CI
Tests Affected
New Tests That Don't Pass
- /shadow-dom/focus-navigation/delegatesFocus-highlight-sibling.html [wpt.fyi]
- crbug/474687 :focus style should properly be applied to shadow hosts.:
FAIL(Safari:PASS)
- crbug/474687 :focus style should properly be applied to shadow hosts.:
- /shadow-dom/focus-navigation/focus-navigation-slot-fallback-default-tabindex.html [wpt.fyi]
- Default tabindex for a slot node should be 0.:
FAIL(Safari:PASS)
- Default tabindex for a slot node should be 0.:
- /shadow-dom/focus-navigation/focus-navigation-slot-fallback.html [wpt.fyi]
- Focus should jump to fallback elements when a slot does not have any assigned nodes.:
FAIL(Safari:PASS)
- Focus should jump to fallback elements when a slot does not have any assigned nodes.:
- /shadow-dom/focus-navigation/focus-navigation-slot-nested-2levels.html [wpt.fyi]
- Focus controller should treat each slot as a focus scope.:
FAIL(Safari:PASS)
- Focus controller should treat each slot as a focus scope.:
- /shadow-dom/focus-navigation/focus-navigation-slot-nested-delegatesFocus.html [wpt.fyi]
- Focus controller should treat each slot as a focus scope.:
FAIL(Safari:PASS)
- Focus controller should treat each slot as a focus scope.:
- /shadow-dom/focus-navigation/focus-navigation-slot-nested-fallback.html [wpt.fyi]
- Focus should cover assigned elements of an assigned slot espacially there are fallback contents.:
FAIL(Safari:PASS)
- Focus should cover assigned elements of an assigned slot espacially there are fallback contents.:
- /shadow-dom/focus-navigation/focus-navigation-slot-nested.html [wpt.fyi]
- Focus controller should treat each slot as a focus scope.:
FAIL(Safari:PASS)
- Focus controller should treat each slot as a focus scope.:
- /shadow-dom/focus-navigation/focus-navigation-slot-shadow-in-fallback.html [wpt.fyi]
- Focus should cover assigned elements of an assigned slot, as well as elements that are directly assigned to a slot.:
FAIL(Safari:PASS)
- Focus should cover assigned elements of an assigned slot, as well as elements that are directly assigned to a slot.:
- /shadow-dom/focus-navigation/focus-navigation-slot-shadow-in-slot.html [wpt.fyi]
- Focus should cover assigned elements of an assigned slot, as well as elements that are directly assigned to a slot.:
FAIL(Safari:PASS)
- Focus should cover assigned elements of an assigned slot, as well as elements that are directly assigned to a slot.:
- /shadow-dom/focus-navigation/focus-navigation-slot-with-tabindex.html [wpt.fyi]
- Slots tabindex should be considred in focus navigation.:
FAIL(Safari:PASS)
- Slots tabindex should be considred in focus navigation.:
- /shadow-dom/focus-navigation/focus-navigation-slots-in-slot.html [wpt.fyi]
- Focus should cover assigned nodes of slot, especially for nested slots in slot scope.:
FAIL(Safari:PASS)
- Focus should cover assigned nodes of slot, especially for nested slots in slot scope.:
- /shadow-dom/focus-navigation/focus-navigation-slots.html [wpt.fyi]
- Focus should cover assigned elements of an assigned slot, as well as elements that are directly assigned to a slot.:
FAIL(Safari:PASS)
- Focus should cover assigned elements of an assigned slot, as well as elements that are directly assigned to a slot.:
- /shadow-dom/focus-navigation/focus-navigation-web-component-radio.html [wpt.fyi]
- Focus for web component input type elements should be bound by <form> inside shadow DOM:
FAIL(Safari:PASS)
- Focus for web component input type elements should be bound by <form> inside shadow DOM:
- /shadow-dom/focus-navigation/focus-navigation-with-delegatesFocus.html [wpt.fyi]
- Testing tab navigation order with mode open, no tabindex and delegatesFocus=false.:
FAIL(Safari:PASS) - Testing tab navigation order with mode open, no tabindex and delegatesFocus=true.:
FAIL(Safari:PASS) - Testing tab navigation order with mode open, tabindex=0 and delegatesFocus=false.:
FAIL(Safari:PASS) - Testing tab navigation order with mode open, tabindex=0 and delegatesFocus=true.:
FAIL(Safari:PASS) - Testing tab navigation order with mode open, tabindex=-1 and delegatesFocus=false.:
FAIL(Safari:PASS) - Testing tab navigation order with mode open, tabindex=-1 and delegatesFocus=true.:
FAIL(Safari:PASS) - Testing tab navigation order with mode open, tabindex=1 and delegatesFocus=false.:
FAIL(Safari:PASS) - Testing tab navigation order with mode open, tabindex=1 and delegatesFocus=true.:
FAIL(Safari:PASS) - Testing tab navigation order with mode closed, no tabindex and delegatesFocus=false.:
FAIL(Safari:PASS) - Testing tab navigation order with mode closed, no tabindex and delegatesFocus=true.:
FAIL(Safari:PASS) - Testing tab navigation order with mode closed, tabindex=0 and delegatesFocus=false.:
FAIL(Safari:PASS) - Testing tab navigation order with mode closed, tabindex=0 and delegatesFocus=true.:
FAIL(Safari:PASS) - Testing tab navigation order with mode closed, tabindex=-1 and delegatesFocus=false.:
FAIL(Safari:PASS) - Testing tab navigation order with mode closed, tabindex=-1 and delegatesFocus=true.:
FAIL(Safari:PASS) - Testing tab navigation order with mode closed, tabindex=1 and delegatesFocus=false.:
FAIL(Safari:PASS) - Testing tab navigation order with mode closed, tabindex=1 and delegatesFocus=true.:
FAIL(Safari:PASS)
- Testing tab navigation order with mode open, no tabindex and delegatesFocus=false.:
- /shadow-dom/focus-navigation/focus-navigation.html [wpt.fyi]
- Focus controller should treat slots as a focus scope.:
FAIL(Safari:PASS)
- Focus controller should treat slots as a focus scope.:
- /shadow-dom/focus-navigation/focus-nested-slots.html [wpt.fyi]
- Verifies that focus order goes in flat tree order with buttons inside nested slots which have a mixture of assigned and unassigned states.:
FAIL(Safari:PASS)
- Verifies that focus order goes in flat tree order with buttons inside nested slots which have a mixture of assigned and unassigned states.:
- /shadow-dom/focus-navigation/focus-unassignable-slot.html [wpt.fyi]
- Verifies that focusing forwards from an input inside a slot which has no shadow root goes to the next focusable element in light DOM.:
FAIL(Safari:PASS)
- Verifies that focusing forwards from an input inside a slot which has no shadow root goes to the next focusable element in light DOM.:
- /shadow-dom/focus-navigation/focus-with-negative-index.html [wpt.fyi]
- Focus controller should treat slots as a focus scope.:
FAIL(Safari:PASS)
- Focus controller should treat slots as a focus scope.:
CI Results
Gecko CI (Treeherder)
GitHub PR Head
Notes
These updates will be on mozilla-central once bug 1892119 lands.
Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.
This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/
If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.
|
||
Comment 1•7 months ago
|
||
Hi Sean, maybe you're interested in taking a quick look at for these new wpt failures? Do they ring any bell?
|
||
Comment 2•7 months ago
|
||
Yeah, looks like some changes made to WPT caused us start to fail, we have been passing for those tests for a long time. I'll continue investigate to see why
|
|
||
Comment 3•7 months ago
|
||
So how the test works is there's a from element that gains the focus initially, then a tab key gets sent to document.documentElement, that supposes to move the focus to the next tabbable element.
However, this document.documentElement is new, it was document.body before the change. Since our marionette code would try to focus the target element, the focused element gets changed to <html> rather than remains at the from element. This is because document.body isn't a legit focusable element, so focusing document.body doesn't blur the existing focus.
I've asked the chrome folks to see if the change was intentional.
|
|
||
Comment 4•6 months ago
|
||
I think they are fixed now because Chrome folks have landed a fix https://chromium-review.googlesource.com/c/chromium/src/+/5519292.
Not sure why m-c doesn't have this change yet.
|
|
||
Comment 5•6 months ago
|
||
I believe this now has been fixed by the above WPT change.
Description
•