1892345 - [wpt-sync] Sync PR 45791 - Support computing light-dark() for registered color syntax

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45791 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45791
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

Support computing light-dark() for registered color syntax

ComputeRegisteredPropertyValue() did not handle light/dark pairs.

Added some more complex computed style tests for registered color
syntax. color-mix() is not supported either. To be fixed in a separate
CL.

Bug: 335383222
Change-Id: Ic7c4dddeb141b71e16aa86fee4df8ef3c5b5bd48
Reviewed-on: https://chromium-review.googlesource.com/5463142
WPT-Export-Revision: 6ebcc04dd38fe398ab42cf216e62a2d96215dd69

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e24d286ecab290ee6b720aa7e71492e2b9e73485

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 72 subtests

Status Summary

Firefox

OK : 2
PASS : 70
FAIL : 4

Chrome

OK : 2
PASS : 68
FAIL : 6

Safari

OK : 1
PASS : 2
CRASH: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-contain/container-queries/registered-color-style-queries.html [wpt.fyi]
  • Registered color with light color-scheme and light-dark(): FAIL (Chrome: FAIL, Safari: PASS)
  • Registered color with dark color-scheme and light-dark(): FAIL (Chrome: FAIL, Safari: PASS)
• /css/css-properties-values-api/registered-property-computation.html [wpt.fyi]
  • <color> values are computed correctly [color-mix(in srgb, currentcolor, red)]: FAIL (Chrome: FAIL)
  • <color> values are computed correctly [color(from lime srgb g g g)]: FAIL (Chrome: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90518be8429c
[wpt PR 45791] - Support computing light-dark() for registered color syntax, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3817d7e2d8d6
[wpt PR 45791] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/90518be8429c
https://hg.mozilla.org/mozilla-central/rev/3817d7e2d8d6