Closed Bug 1892399 Opened 1 year ago Closed 1 year ago

Add Ahem font to allow list when installed

Categories

(Testing :: web-platform-tests, enhancement, P1)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox127 fixed)

Status:
RESOLVED FIXED
Milestone:
127 Branch
Tracking Flags:
Tracking Status
firefox127 --- fixed

People

(Reporter: bobowen, Assigned: bobowen)

References

Details

Attachments

(1 file)

Bug 1892399: Add Ahem font to allow list when installed by wptrunner. r=jgraham!
48 bytes, text/x-phabricator-request
Details | Review

The Ahem font is added to a test path when the install_fonts argument is passed.
Currently the content process happens to have read access to the location, but it will be lost once we move to a USER_RESTRICTED access token level.
We need to add the font file to an allow list of paths for the tests to continue to work.

This also renames the white list variables in the associated test files to allow
list. The pref name is not so straight forward to change.

Pushed by bobowencode@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f92ab527c47b Add Ahem font to allow list when installed by wptrunner. r=jgraham

Backed out for causing wpt failures in wptrunner

[task 2024-04-22T09:50:03.926Z] 09:50:03     INFO - SUITE-START | Running 1 tests
[task 2024-04-22T09:50:03.927Z] 09:50:03     INFO - Using 1 child processes
[task 2024-04-22T09:50:03.929Z] 09:50:03 CRITICAL - Uncaught exception in TestRunnerManager.run:
[task 2024-04-22T09:50:03.929Z] 09:50:03 CRITICAL - Traceback (most recent call last):
[task 2024-04-22T09:50:03.929Z] 09:50:03 CRITICAL -   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/testrunner.py", line 423, in run_loop
[task 2024-04-22T09:50:03.929Z] 09:50:03 CRITICAL -     new_state = f()
[task 2024-04-22T09:50:03.929Z] 09:50:03 CRITICAL -   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/testrunner.py", line 565, in init
[task 2024-04-22T09:50:03.929Z] 09:50:03 CRITICAL -     browser = impl.browser_cls(self.logger, remote_queue=self.command_queue,
[task 2024-04-22T09:50:03.929Z] 09:50:03 CRITICAL -   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox_android.py", line 228, in __init__
[task 2024-04-22T09:50:03.929Z] 09:50:03 CRITICAL -     self.profile_creator = ProfileCreator(logger,
[task 2024-04-22T09:50:03.929Z] 09:50:03 CRITICAL -   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox_android.py", line 153, in __init__
[task 2024-04-22T09:50:03.929Z] 09:50:03 CRITICAL -     super().__init__(logger, prefs_root, config, test_type, extra_prefs,
[task 2024-04-22T09:50:03.929Z] 09:50:03 CRITICAL - TypeError: __init__() missing 1 required positional argument: 'allow_list_paths'
[task 2024-04-22T09:50:03.929Z] 09:50:03 CRITICAL - 
[task 2024-04-22T09:50:03.929Z] 09:50:03     INFO - No more tests
[task 2024-04-22T09:50:03.930Z] 09:50:03     INFO - SUITE-END | took 0s
[task 2024-04-22T09:50:03.931Z] 09:50:03     INFO - Got 0 unexpected results, with 0 unexpected passes
[task 2024-04-22T09:50:03.931Z] 09:50:03     INFO - STDERR: Exception in thread 
[task 2024-04-22T09:50:03.931Z] 09:50:03     INFO - STDERR: TestRunnerManager-0
[task 2024-04-22T09:50:03.932Z] 09:50:03     INFO - STDERR: :
[task 2024-04-22T09:50:03.932Z] 09:50:03     INFO - STDERR: Traceback (most recent call last):
[task 2024-04-22T09:50:03.933Z] 09:50:03     INFO - STDERR:   File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
[task 2024-04-22T09:50:03.933Z] 09:50:03     INFO - STDERR:     
[task 2024-04-22T09:50:03.933Z] 09:50:03     INFO - STDERR: self.run()
[task 2024-04-22T09:50:03.933Z] 09:50:03     INFO - STDERR:   File "/usr/lib/python3.8/threading.py", line 870, in run
[task 2024-04-22T09:50:03.934Z] 09:50:03     INFO - STDERR:     
[task 2024-04-22T09:50:03.934Z] 09:50:03     INFO - STDERR: self._target(*self._args, **self._kwargs)
[task 2024-04-22T09:50:03.934Z] 09:50:03     INFO - STDERR:   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/testrunner.py", line 423, in run_loop
[task 2024-04-22T09:50:03.935Z] 09:50:03     INFO - STDERR:     
[task 2024-04-22T09:50:03.935Z] 09:50:03     INFO - STDERR: new_state = f()
[task 2024-04-22T09:50:03.935Z] 09:50:03     INFO - STDERR:   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/testrunner.py", line 565, in init
[task 2024-04-22T09:50:03.936Z] 09:50:03     INFO - STDERR:     
[task 2024-04-22T09:50:03.936Z] 09:50:03     INFO - STDERR: browser = impl.browser_cls(self.logger, remote_queue=self.command_queue,
[task 2024-04-22T09:50:03.936Z] 09:50:03     INFO - STDERR:   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox_android.py", line 228, in __init__
[task 2024-04-22T09:50:03.937Z] 09:50:03     INFO - STDERR:     
[task 2024-04-22T09:50:03.937Z] 09:50:03     INFO - STDERR: self.profile_creator = ProfileCreator(logger,
[task 2024-04-22T09:50:03.937Z] 09:50:03     INFO - STDERR:   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/browsers/firefox_android.py", line 153, in __init__
[task 2024-04-22T09:50:03.938Z] 09:50:03     INFO - STDERR:     
[task 2024-04-22T09:50:03.938Z] 09:50:03     INFO - STDERR: super().__init__(logger, prefs_root, config, test_type, extra_prefs,
[task 2024-04-22T09:50:03.938Z] 09:50:03     INFO - STDERR: TypeError
[task 2024-04-22T09:50:03.939Z] 09:50:03     INFO - STDERR: : 
[task 2024-04-22T09:50:03.939Z] 09:50:03     INFO - STDERR: __init__() missing 1 required positional argument: 'allow_list_paths'
[task 2024-04-22T09:50:03.939Z] 09:50:03     INFO - wptserve Stopped WebTransport over HTTP/3 server on 127.0.0.1:11000
[task 2024-04-22T09:50:04.312Z] 09:50:04     INFO - wptserve Stopped http server on 127.0.0.1:8003
[task 2024-04-22T09:50:04.312Z] 09:50:04     INFO - wptserve Stopped http server on 127.0.0.1:8001
[task 2024-04-22T09:50:04.313Z] 09:50:04     INFO - wptserve Stopped http server on 127.0.0.1:8002
[task 2024-04-22T09:50:04.314Z] 09:50:04     INFO - wptserve Stopped http server on 127.0.0.1:8443
[task 2024-04-22T09:50:04.314Z] 09:50:04     INFO - wptserve Stopped http server on 127.0.0.1:8445
[task 2024-04-22T09:50:04.315Z] 09:50:04     INFO - wptserve Stopped http server on 127.0.0.1:8446
[task 2024-04-22T09:50:04.329Z] 09:50:04     INFO - wptserve Stopped http server on 127.0.0.1:8000
[task 2024-04-22T09:50:04.332Z] 09:50:04     INFO - wptserve Stopped http server on 127.0.0.1:8444
[task 2024-04-22T09:50:04.333Z] 09:50:04     INFO - wptserve Close on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 8889))
[task 2024-04-22T09:50:04.335Z] 09:50:04     INFO - wptserve Stopped http server on 127.0.0.1:9000
[task 2024-04-22T09:50:04.336Z] 09:50:04     INFO - wptserve Close on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 8888))
[task 2024-04-22T09:50:04.450Z] 09:50:04     INFO - Removed font: Ahem.ttf
[task 2024-04-22T09:50:04.511Z] 09:50:04     INFO - Closing logging queue
[task 2024-04-22T09:50:04.511Z] 09:50:04     INFO - queue closed
[task 2024-04-22T09:50:04.539Z] 09:50:04 CRITICAL - No tests ran
[task 2024-04-22T09:50:04.953Z] 09:50:04     INFO - Return code: 1
[task 2024-04-22T09:50:04.953Z] 09:50:04    ERROR - No checks run.
Flags: needinfo?(bobowencode)
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45820 for changes under testing/web-platform/tests

I missed that there is a subclass of ProfileCreator for android (partly because it aliases the original as FirefoxProfileCreator and then calls its own ProfileCreator).
New try push:
https://treeherder.mozilla.org/jobs?repo=try&revision=f99c245f1902c715a186ec924abc79403e26a0c8

Flags: needinfo?(bobowencode)
Upstream PR was closed without merging
Pushed by bobowencode@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c889e3972268 Add Ahem font to allow list when installed by wptrunner. r=jgraham

https://hg.mozilla.org/mozilla-central/rev/c889e3972268

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox127: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
Upstream PR was closed without merging
See Also: → 1893190
Upstream PR was closed without merging
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: