1892404 - [UI/UX] Part 1: Create the scaffolding for the micro survey view

Status: RESOLVED FIXED

(Fenix :: Experimentation and Telemetry, task, P1)

Description

[Rebeca Tudor]

Please check the Figma designs for the most up-to date requirements.

Note: Place holder text can be used. Ideally this implementation will work for both the existing address bar and the WIP navigation bar UIs.

The view is expected to behave in the same manner as a Bottom Sheet. Note from UX:

The survey is in a bottom sheet so it should behave like all bottom sheets. If we only open it part way, then you can tap outside and it will dismiss. If it's open all the way you have to tap the close or drag it down to dismiss. The prompt will remain there until you either complete the survey or dismiss it.

This will likely take shape in the form of a bare bones Compose pop-up dialog consisting of an open and closed state based on the design. Essentially a blank ‘dialog’ that can expand/collapse. The expand/collapse action is based on pressing a button, not scrolling.

Comment 1

[Rebeca Tudor]

Attachment: Bug 1892404 - Create the scaffolding for the micro survey view

It was created an empty card that can be opened or closed.
This card will serve as scaffold for the micro-survey view.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb56c1e77ad2
Create the scaffolding for the micro survey view r=android-reviewers,twhite

Comment 3

[tszentpeteri]

Backed out for causing fenix linting failure.

• Backout link
• Push with failures
• Failure Log
• Failure line:

[task 2024-04-22T08:40:19.269Z] > Task :detekt FAILED
[task 2024-04-22T08:40:19.269Z] /builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/microsurvey/ui/MicroSurveyScaffold.kt:25:5: The function MicroSurveyScaffold is missing documentation. [UndocumentedPublicFunction]
[task 2024-04-22T08:40:19.269Z] 
[task 2024-04-22T08:40:19.269Z] /builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/microsurvey/ui/MicroSurveyScaffold.kt - 20min debt
[task 2024-04-22T08:40:19.269Z] 	UndocumentedPublicFunction - [The function MicroSurveyScaffold is missing documentation.] at /builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/microsurvey/ui/MicroSurveyScaffold.kt:25:5
[task 2024-04-22T08:40:19.269Z] 
[task 2024-04-22T08:40:19.269Z] Overall debt: 20min
[task 2024-04-22T08:40:19.269Z] 
[task 2024-04-22T08:40:19.269Z] comments - 20min debt
[task 2024-04-22T08:40:19.269Z] 	UndocumentedPublicFunction - [The function MicroSurveyScaffold is missing documentation.] at /builds/worker/checkouts/gecko/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/microsurvey/ui/MicroSurveyScaffold.kt:25:5
[task 2024-04-22T08:40:19.269Z] 
[task 2024-04-22T08:40:19.269Z] Overall debt: 20min
[task 2024-04-22T08:40:19.269Z] 
[task 2024-04-22T08:40:19.269Z] Complexity Report:
[task 2024-04-22T08:40:19.269Z] 	- 116,397 lines of code (loc)
[task 2024-04-22T08:40:19.269Z] 	- 85,931 source lines of code (sloc)
[task 2024-04-22T08:40:19.269Z] 	- 58,065 logical lines of code (lloc)
[task 2024-04-22T08:40:19.269Z] 	- 17,223 comment lines of code (cloc)
[task 2024-04-22T08:40:19.269Z] 	- 10,234 cyclomatic complexity (mcc)
[task 2024-04-22T08:40:19.269Z] 	- 5,321 cognitive complexity
[task 2024-04-22T08:40:19.269Z] 	- 1 number of total code smells
[task 2024-04-22T08:40:19.269Z] 	- 20% comment source ratio
[task 2024-04-22T08:40:19.269Z] 	- 176 mcc per 1,000 lloc
[task 2024-04-22T08:40:19.269Z] 	- 0 code smells per 1,000 lloc
[task 2024-04-22T08:40:19.269Z] 
[task 2024-04-22T08:40:19.269Z] Project Statistics:
[task 2024-04-22T08:40:19.269Z] 	- number of properties: 5263
[task 2024-04-22T08:40:19.269Z] 	- number of functions: 4464
[task 2024-04-22T08:40:19.269Z] 	- number of classes: 1607
[task 2024-04-22T08:40:19.269Z] 	- number of packages: 186
[task 2024-04-22T08:40:19.269Z] 	- number of kt files: 904
[task 2024-04-22T08:40:19.269Z] 
[task 2024-04-22T08:40:19.269Z] Successfully generated SARIF: a standard format for the output of static analysis tools at file:///builds/worker/checkouts/gecko/mobile/android/fenix/build/reports/detekt/detekt.sarif
[task 2024-04-22T08:40:19.269Z] Successfully generated Checkstyle XML report at file:///builds/worker/checkouts/gecko/mobile/android/fenix/build/reports/detekt/detekt.xml
[task 2024-04-22T08:40:19.269Z] Successfully generated plain text report at file:///builds/worker/checkouts/gecko/mobile/android/fenix/build/reports/detekt/detekt.txt
[task 2024-04-22T08:40:19.269Z] Successfully generated HTML report at file:///builds/worker/checkouts/gecko/mobile/android/fenix/build/reports/detekt/detekt.html
[task 2024-04-22T08:40:19.269Z] Successfully generated Markdown report at file:///builds/worker/checkouts/gecko/mobile/android/fenix/build/reports/detekt/detekt.md
[task 2024-04-22T08:40:19.369Z] 
[task 2024-04-22T08:40:19.369Z] FAILURE: Build failed with an exception.
[task 2024-04-22T08:40:19.369Z] 
[task 2024-04-22T08:40:19.369Z] * What went wrong:
[task 2024-04-22T08:40:19.369Z] Execution failed for task ':detekt'.
[task 2024-04-22T08:40:19.369Z] > Analysis failed with 1 weighted issues.
[task 2024-04-22T08:40:19.369Z] 
[task 2024-04-22T08:40:19.369Z] * Try:
[task 2024-04-22T08:40:19.369Z] > Run with --stacktrace option to get the stack trace.
[task 2024-04-22T08:40:19.369Z] > Run with --info or --debug option to get more log output.
[task 2024-04-22T08:40:19.369Z] > Run with --scan to get full insights.
[task 2024-04-22T08:40:19.369Z] > Get more help at https://help.gradle.org.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/710d2ff1f9bb
Create the scaffolding for the micro survey view r=android-reviewers,twhite

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/710d2ff1f9bb