1892440 - Expose chrome only method to flip HttpChannel's StoreRequestObserversCalled

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P2)

Description

[Julian Descottes [:jdescottes]]

For WebDriver BiDi, we need to be able to update the method and body of the request rather late in the lifecycle (see observer notification added in bug 1849686).

At that point modifying the body or the method of a request currently throws with NS_ERROR_IN_PROGRESS.
To work around this, we can expose a method in order to flip StoreRequestObserversCalled while WebDriverBiDi needs to update those properties. In the long term we probably need a better way to allow a specific part of the codebase to update those properties so that it can't be abused by eg webextensions.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1892440 - Expose RequestObserversCalled attribute in nsIHttpChannel

For WebDriver BiDi network interception we need to be able to modify the request as late as possible.
This changeset exposes RequestObserversCalled to JS so that we can update it from the webdriver bidi codebase.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/473cfde59352
Expose RequestObserversCalled attribute in nsIHttpChannel r=valentin,necko-reviewers

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/473cfde59352