1892445 - 10 bit RGB AV1 video broken on Linux

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: 10bit-rgb.mp4

It's mostly green with vertical stripes. It works on Windows and macOS.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=38711fbec2b1e046cc8261e5f5a36833c00cacca&tochange=afb99f2fbec3d8dd7e10978354a73bc29c3765d7

Suspect: Bug 1745285

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1745285

:stransky, since you are the author of the regressor, bug 1745285, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Paul Adenot (:padenot)]

Pernosco session of this, https://pernos.co/debug/ZP6-KJAivXPSOw-ftTyNOg/index.html#f{m[BkoG,S1o_,t[Ah8,O3aB_,f{e[BkoG,Sao_,s{aci2xwAAA,bAZU,uFJeF4Q,oFKQ9ZA___/ for whoever gets to it first. Happy to help if unfamilar with pernosco.

Comment 4

[Donal Meehan [:dmeehan]]

:jimm could this be triaged for severity?

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Looks like we're missing implementation for AV_PIX_FMT_GBRP10LE on FFmpeg side.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1892445 [Linux] Add support for AV1 10bit video format AV_PIX_FMT_GBRP10LE r?alwu

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7558b1bd11aa
[Linux] Add support for AV1 10bit video format AV_PIX_FMT_GBRP10LE r=alwu

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7558b1bd11aa

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9402228 [details]
Bug 1892445 [Linux] Add support for AV1 10bit video format AV_PIX_FMT_GBRP10LE r?alwu

Beta/Release Uplift Approval Request

• User impact if declined: Broken playback of AV1 10bit RGB video format.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open the attached video clip in Firefox.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We already use the code path for other formats.
• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9402228 [details]
Bug 1892445 [Linux] Add support for AV1 10bit video format AV_PIX_FMT_GBRP10LE r?alwu

Approved for 127 beta 6, thanks.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8451c43a0350

Comment 13

[Raluca Popovici, Desktop QA]

Reproduced the issue on Firefox 115.0.1 esr on Ubuntu 24.04 LTS by following the infos provided in Comment 10.

The issue is no longer reproducible on Firefox 127.0b6 and Firefox 128.0a1 (2024-05-24) on the same system.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

How common is this in the wild? I'm inclined to wontfix ESR115 and let this ride to those users with the upcoming ESR128 release. SGTY?

Comment 15

[Martin Stránský [:stransky] (ni? me)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #14)

How common is this in the wild? I'm inclined to wontfix ESR115 and let this ride to those users with the upcoming ESR128 release. SGTY?

No idea, haven't seen such clip yet. Should be safe to keep it for ESR128.