1892457 - 10 bit RGB AV1 video broken on macOS M3

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Example https://bugzilla.mozilla.org/attachment.cgi?id=9397576

Mostly likely broken by AV1 hardware acceleration.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1871796

Comment 2

[Paul Adenot (:padenot)]

Jeff says that QuickTime plays 10-bits YUV420 files, so that's likely supported on M3. We want to play all av1 files so we need to parse the seq header in the metadata, and dispatch to libdav1d for 12-bits YUV420, and then 10 and 12-bits RGB (libdav1d supports everything).

Fixing https://bugzilla.mozilla.org/show_bug.cgi?id=1892457 + switching over AV1 decoding with libdav1d to FFmpegVideoDecoder on all platforms seems to be the route that is preferable, to consolidate things a bit.

Comment 3

[Donal Meehan [:dmeehan]]

:jrmuizel what's the impact and priority on fixing this fix Fx126? (Next week is the final week of Fx126 beta)

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1892457. Don't use the HW AV1 decoder for 12 bit or RGB video.

It doesn't seem to work. Confirmed by trying with Quicktime.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9398175 [details]
Bug 1892457. Don't use the HW AV1 decoder for 12 bit or RGB video.

Beta/Release Uplift Approval Request

• User impact if declined: 12 bit and RGB AV1 videos won't play for users with M3 macs
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It just disables using the hardware video decoder when we see videos that won't work.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffa4703b3c60
Don't use the HW AV1 decoder for 12 bit or RGB video. r=padenot

Comment 7

[Cristian Tuns]

Backed out for causing build bustages in AppleDecoderModule.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/media/platforms/apple/AppleDecoderModule.cpp:163:35: error: use of undeclared identifier 'YUVColorSpace'

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9398175 [details]
Bug 1892457. Don't use the HW AV1 decoder for 12 bit or RGB video.

Rejecting uplift, patched causing issues on autoland

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71fca2c086ca
Don't use the HW AV1 decoder for 12 bit or RGB video. r=padenot

Comment 10

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/71fca2c086ca

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9398175 [details]
Bug 1892457. Don't use the HW AV1 decoder for 12 bit or RGB video.

Beta/Release Uplift Approval Request

• User impact if declined: 12 bit and RGB AV1 videos won't play for users with M3 macs
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It just disables using the hardware video decoder when we see videos that won't work.
• String changes made/needed:
• Is Android affected?: No

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9398175 [details]
Bug 1892457. Don't use the HW AV1 decoder for 12 bit or RGB video.

Approved for 126.0b6

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/cda434ac6f3d