1892487 - Home and newtab wallpaper customize menu thumbnails don't tab

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Scott [:thecount] Downe]

Not totally sure why this doesn't just work. They are inputs, so should have default tabbing behaviour. However, it does not work.

[Tracking Requested - why for this release]: UX and possible a11y issue

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1881588

:nbarrett, since you are the author of the regressor, bug 1881588, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco]]

The bug is marked as tracked for firefox126 (beta). However, the bug still isn't assigned.

:amy, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 3

[Donal Meehan [:dmeehan]]

:thecount adding a reminder that next week is the final week of beta for Fx126.
There's not much time left to fix this and request uplift.

Comment 4

[Nathan Barrett [:nbarrett]]

Attachment: Bug 1892487 - Fix tabbing issue with wallpaper thumbnails r=maxx

Comment 5

[Nathan Barrett [:nbarrett]]

:dmeehan - I'll fill out an uplift request once this lands, thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43278981d771
Fix tabbing issue with wallpaper thumbnails r=maxx,omc-reviewers,home-newtab-reviewers,emcminn

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing node newtab failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/b116e0de592127d8cab7c102c1f35a9f6a365258

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | bundles | aboutwelcome.css out of date

TEST-START | bundles
[task 2024-04-25T22:01:23.692Z] TEST-UNEXPECTED-FAIL | bundles | aboutwelcome.css out of date
[task 2024-04-25T22:01:23.692Z] TEST-START | karma /builds/worker/checkouts/gecko/browser/components/newtab
[task 2024-04-25T22:01:40.506Z] webpack was not included as a framework in karma configuration, setting this automatically...
[task 2024-04-25T22:01:40.514Z] TEST-UNEXPECTED-FAIL | karma /builds/worker/checkouts/gecko/browser/components/newtab | activity-stream:<BaseContent> should remove the event listener for visibility change when unmounted: __webpack_require__.g.prefersDarkQuery is undefined
[task 2024-04-25T22:01:40.514Z] componentWillUnmount@http://localhost:9876/absolute/tmp/_karma_webpack_377794/commons.js?16eb11a5e7c4c498bb5032217fd93d339833c476:103431:5
[task 2024-04-25T22:01:40.514Z] unmount@http://localhost:9876/absolute/tmp/_karma_webpack_377794/commons.js?16eb11a5e7c4c498bb5032217fd93d339833c476:37110:24
[task 2024-04-25T22:01:40.514Z] unmount@http://localhost:9876/absolute/tmp/_karma_webpack_377794/commons.js?16eb11a5e7c4c498bb5032217fd93d339833c476:2111:20
[task 2024-04-25T22:01:40.514Z] unmount@http://localhost:9876/absolute/tmp/_karma_webpack_377794/commons.js?16eb11a5e7c4c498bb5032217fd93d339833c476:71778:24
[task 2024-04-25T22:01:40.514Z] @http://localhost:9876/absolute/tmp/_karma_webpack_377794/commons.js?16eb11a5e7c4c498bb5032217fd93d339833c476:99236:13
[task 2024-04-25T22:01:40.514Z] 
[task 2024-04-25T22:01:40.514Z] -----karma stdout below this line---

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/954f1c6ff28d
Fix tabbing issue with wallpaper thumbnails r=maxx,omc-reviewers,home-newtab-reviewers,emcminn

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/954f1c6ff28d

Comment 10

[Nathan Barrett [:nbarrett]]

Comment on attachment 9398648 [details]
Bug 1892487 - Fix tabbing issue with wallpaper thumbnails r=maxx

Beta/Release Uplift Approval Request

• User impact if declined: The wallpaper sections in newtab and the onboarding modal will not be able to tab
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Slightly updated markup and css to enable tabbing
• String changes made/needed:
• Is Android affected?: No

Comment 11

[Donal Meehan [:dmeehan]]

Comment on attachment 9398648 [details]
Bug 1892487 - Fix tabbing issue with wallpaper thumbnails r=maxx

Approved for 126.0b8

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/340f953b8902