1892516 - Record scalar `device_hardware_decoding_support` on all platforms

Status: RESOLVED FIXED

(Core :: Audio/Video, task, P1)

Description

[Alastor Wu [:alwu]]

We want to extend this probe device_hardware_decoding_support on more platforms, which currently is only available on Windows. In addition, we would also like to report false if user don't have the codec support.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1892516 - part1 : explicitly disable HEVC support to avoid running the initialization again.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1892516 - part2 : report false for unsupported codecs.

Depends on D208243

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1892516 - part3 : use Glean API and report the probe on more platforms.

Depends on D208244

Comment 4

[Alastor Wu [:alwu]]

Attachment: data-review-request

Comment 5

[Chris H-C :chutten]

Comment on attachment 9398262 [details]
data-review-request

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through the product's preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Alastor Wu and [e-mail] will be responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1cebb819ab9
part1 : explicitly disable HEVC support to avoid running the initialization again. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/5155a959fe13
part2 : report false for unsupported codecs. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/842a809422f9
part3 : use Glean API and report the probe on more platforms. r=padenot

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing multiple failures @ toolkit/components/glean/api/src/private/boolean.rs

Backout link: https://hg.mozilla.org/integration/autoland/rev/f24ffc487097df9a1f47efcc366ebecf14b42b26

Push with failures

Failure log -> Hit MOZ_CRASH(Attempted to set boolean metric in non-main process, which is forbidden. This panics in automation.) at toolkit/components/glean/api/src/private/boolean.rs

[ERROR firefox_on_glean::private::boolean] Unable to set boolean metric in non-main process. This operation will be ignored.
[task 2024-04-25T18:18:05.599Z] 18:18:05     INFO - GECKO(8304) | [4408] Hit MOZ_CRASH(Attempted to set boolean metric in non-main process, which is forbidden. This panics in automation.) at toolkit/components/glean/api/src/private/boolean.rs:61
[task 2024-04-25T18:18:05.657Z] 18:18:05     INFO - GECKO(8304) | [WARN  webrender::device::gl] Cropping texture upload Box2D((0, 0), (0, 1)) to None

Comment 8

[Chris H-C :chutten]

(Ah, this is https://firefox-source-docs.mozilla.org/toolkit/components/glean/dev/ipc.html#forbidding-non-commutative-operations )

Comment 9

[Alastor Wu [:alwu]]

Attachment: Bug 1892516 - part4 : no need to reinit WMF PDM in the RDD process because we only do hardware decoding via WMF on GPU process.

Comment 10

[Alastor Wu [:alwu]]

Attachment: Bug 1892516 - part5 : report Glean probe from the chrome process.

According to [1], currently we can only set a labeled boolean from the
chrome process, so we need to adjust our design to report result from
reporting from the GPU/RDD process to the chrome process.

Therefore, we have to always check HEVC first, and trim it later in
order to not to incorrectly support HEVC if the pref for HEVC is off.

[1] https://firefox-source-docs.mozilla.org/toolkit/components/glean/dev/ipc.html#forbidding-non-commutative-operations

Depends on D208715

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1e2f8b3c62a
part1 : explicitly disable HEVC support to avoid running the initialization again. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/1b7a0986457b
part2 : report false for unsupported codecs. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/6d4b0303e1aa
part3 : use Glean API and report the probe on more platforms. r=padenot
https://hg.mozilla.org/integration/autoland/rev/1a012d9139ca
part4 : no need to reinit WMF PDM in the RDD process because we only do hardware decoding via WMF on GPU process. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/8352f9721010
part5 : report Glean probe from the chrome process. r=media-playback-reviewers,padenot

Comment 12

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/f1e2f8b3c62a
https://hg.mozilla.org/mozilla-central/rev/1b7a0986457b
https://hg.mozilla.org/mozilla-central/rev/6d4b0303e1aa
https://hg.mozilla.org/mozilla-central/rev/1a012d9139ca
https://hg.mozilla.org/mozilla-central/rev/8352f9721010