1892551 - Remove pre-SHIP Session History Implementation

Status: ASSIGNED

(Core :: DOM: Navigation, task)

Description

[Adam Vandolder [:avandolder]]

Once "Ship SHIP Everywhere" has been accomplished, the remaining pre-SHIP session history implementation can be removed.

Comment 1

[Adam Vandolder [:avandolder]]

Attachment: Bug 1892551 - Part 1: Update tests for SHIP. r?#dom-core,peterv,farre

Comment 2

[Adam Vandolder [:avandolder]]

Attachment: Bug 1892551 - Part 2: Remove SessionHistoryInParent conditionals. r?#dom-core,peterv,farre

Comment 3

[Adam Vandolder [:avandolder]]

Attachment: Bug 1892551 - Part 3: Remove disableSessionHistoryInParent pref. r?#dom-core,peterv,farre

Comment 4

[Adam Vandolder [:avandolder]]

Attachment: Bug 1892551 - Part 4: Remove nsSHEntry and nsSHEntryShared. r?#dom-core,peterv,farre

Comment 5

[Adam Vandolder [:avandolder]]

Attachment: Bug 1892551 - Part 5: Remove now-unnecessary usage of nsISHEntry. r?#dom-core,peterv,farre

Comment 6

[[:owlish] 🦉 PST]

Hi Adam, We haven't rolled SHIP on Android yet. I would not merge these patches now. Or am I missing something?

Comment 7

[Peter Van der Beken [:peterv]]

This is just preparation for when SHIP has been enabled by default everywhere. This won't land before it has been turned on and shipped for a while on Android too.

Comment 8

[Adam Vandolder [:avandolder]]

Attachment: Bug 1892551 - Part 6: Remove now-unused attributes and methods from nsISHEntry. r?peterv,farre,#dom-core

Comment 9

[[:owlish] 🦉 PST]

Just curious, if this is just a preparation, why do we need to review it now?

Comment 10

[Adam Vandolder [:avandolder]]

Attachment: Bug 1892551 - Part 7: Remove unused parameter from ResumeRedirectedLoad. r?peterv,farre,#dom-core

Comment 11

[Adam Vandolder [:avandolder]]

Attachment: WIP: Bug 1892551 - Part 8: Remove SHIP checks from GeckoView. r?#geckoview-reviewers

Comment 12

[Adam Vandolder [:avandolder]]

Ah, there's no specific need to have these patches reviewed before SHIP on Android is enabled. I've separated out the changes that occur within GeckoView to a separate patch, and I can leave it as WIP for now if you think that's preferable.