1892647 - Silence from spammy warnings in toolkit/components/antitracking/AntiTrackingUtils.cpp

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1892647. Silence from spammy warnings in toolkit/components/antitracking/AntiTrackingUtils.cpp. r?#anti-tracking-reviewers,timhuang,bvandersloot

These warnings print a lot, eg during crashtests. The uris that I was seeing for the documents/channels was about:newtab and data uris.

The specifics of the failure are that the GetBaseDomain call here fails

https://searchfox.org/mozilla-central/rev/863aef60f9fa1536884252ad90cad1d8ee9d8a41/dom/base/ThirdPartyUtil.cpp#347

because there is no base domain of those uris. Specifically, we hit this return

https://searchfox.org/mozilla-central/rev/863aef60f9fa1536884252ad90cad1d8ee9d8a41/dom/base/ThirdPartyUtil.cpp#434

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1876575

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5defbd73591
Silence from spammy warnings in toolkit/components/antitracking/AntiTrackingUtils.cpp. r=timhuang,anti-tracking-reviewers

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c5defbd73591

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:tnikkel, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox126 to wontfix.

For more information, please visit BugBot documentation.