1892705 - swr.getNotifications()[0].icon does not give the resolved URL

Status: RESOLVED FIXED

(Core :: DOM: Notifications, defect)

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1892705 - Persist fully resolved icon URL r=asuth,hsingh

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: WIP: Bug 1892705 - Part 2: Adjust existing mochitests r=asuth

Removing testGet() as that's now covered in WPT in D209008 and D208132, and adjusted dedicated worker tests as WPT doesn't cover non-service workers yet.

(The tests should ideally become .any.js tests but we have no testdriver support in workers 😞. I wonder we can somehow work it around by having something like // META: permission=notification;granted.)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b26a4176031
Persist fully resolved icon URL r=asuth

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46668 for changes under testing/web-platform/tests

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing multiple failures.

• Backout link

---

• Push with failures - mochitests failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | dom/notification/test/mochitest/test_notification_basics.html | icon should get set - got "http://mochi.test:8888/tests/dom/notification/test/mochitest/icon.jpg", expected "icon.jpg"

---

• Push with failures - wpt failures
• Failure Log
• Failure line: PROCESS-CRASH | MOZ_ASSERT(NS_IsMainThread()) (Wrong thread!) [@ mozilla::AssertIsOnMainThread] | /notifications/getnotifications-across-processes.https.window.html

---

• Push with failures - junit failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | runjunit.py | Some tests did not run (probably due to a crash in the harness)

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

Oops!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b98e368f9ae3
Persist fully resolved icon URL r=asuth,hsingh

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b98e368f9ae3

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot