1892721 - Track wasm ref types directly on MIR nodes

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P2)

Description

[Ben Visness [:bvisness]]

We can improve the efficiency of wasm casts by tracking types directly in the MIR graph. Doing so would allow us to freely reorder the creation and manipulation of ref values without being constrained by the wasm validation stack as we are today.

Comment 1

[Ben Visness [:bvisness]]

Attachment: Bug 1892721: Track wasm ref types directly on MIR nodes. r=rhunt

Comment 2

[Ben Visness [:bvisness]]

Attachment: Bug 1892721: Make iongraph prettier. r=iain

Depends on D208139

Comment 3

[Phabricator Automation]

Comment on attachment 9439807 [details]
Bug 1892721: Make iongraph prettier. r=iain

Revision D230165 was moved to bug 1947314. Setting attachment 9439807 [details] to obsolete.

Comment 4

[Ben Visness [:bvisness]]

Attachment: Bug 1892721: Use ref type from input in cast/test operations. r=rhunt

Comment 5

[Ben Visness [:bvisness]]

Attachment: Bug 1892721: Track ref types on nulls. r=rhunt

Comment 6

[Ben Visness [:bvisness]]

Attachment: Bug 1892721: Track ref types on i31.new. r=rhunt

Comment 7

[Ben Visness [:bvisness]]

Attachment: Bug 1892721: Track ref types on new structs and arrays. r=rhunt

Comment 8

[Ben Visness [:bvisness]]

Attachment: Bug 1892721: Track ref types on phis. r=rhunt

Comment 9

[Ben Visness [:bvisness]]

Attachment: Bug 1892721: Track ref types on wasm parameters. r=rhunt

Comment 10

[Ben Visness [:bvisness]]

Attachment: Bug 1892721: Track ref types on any <-> extern conversions. r=rhunt

Comment 11

[Ben Visness [:bvisness]]

Attachment: WIP: Bug 1892721: Convert MWasmTrapIfNull to MWasmRefAsNonNull

Comment 12

[Phabricator Automation]

Comment on attachment 9468679 [details]
Bug 1892721: Track ref types on nulls. r=rhunt

Revision D239767 was moved to bug 1950683. Setting attachment 9468679 [details] to obsolete.

Comment 13

[Phabricator Automation]

Comment on attachment 9468680 [details]
Bug 1892721: Track ref types on i31.new. r=rhunt

Revision D239768 was moved to bug 1950683. Setting attachment 9468680 [details] to obsolete.

Comment 14

[Phabricator Automation]

Comment on attachment 9468681 [details]
Bug 1892721: Track ref types on new structs and arrays. r=rhunt

Revision D239769 was moved to bug 1950683. Setting attachment 9468681 [details] to obsolete.

Comment 15

[Phabricator Automation]

Comment on attachment 9468683 [details]
Bug 1892721: Track ref types on phis. r=rhunt

Revision D239770 was moved to bug 1950683. Setting attachment 9468683 [details] to obsolete.

Comment 16

[Phabricator Automation]

Comment on attachment 9468684 [details]
Bug 1892721: Track ref types on wasm parameters. r=rhunt

Revision D239771 was moved to bug 1950683. Setting attachment 9468684 [details] to obsolete.

Comment 17

[Phabricator Automation]

Comment on attachment 9468685 [details]
Bug 1892721: Track ref types on any <-> extern conversions. r=rhunt

Revision D239772 was moved to bug 1950683. Setting attachment 9468685 [details] to obsolete.

Comment 18

[Phabricator Automation]

Comment on attachment 9468686 [details]
WIP: Bug 1892721: Convert MWasmTrapIfNull to MWasmRefAsNonNull

Revision D239773 was moved to bug 1949849. Setting attachment 9468686 [details] to obsolete.

Comment 20

[Phabricator Automation]

Comment on attachment 9468678 [details]
Bug 1892721: Use ref type from input in cast/test operations. r=rhunt

Revision D239766 was moved to bug 1951158. Setting attachment 9468678 [details] to obsolete.

Comment 21

[Ben Visness [:bvisness]]

Attachment: Bug 1892721: Track ref types on field/element loads. r=rhunt

Depends on D239772

Comment 22

[Ben Visness [:bvisness]]

Attachment: Bug 1892721: Track ref types on some MWasmRegisterResults. r=rhunt

Depends on D240392

Comment 23

[Ben Visness [:bvisness]]

Attachment: Bug 1892721: Track ref types on table elems. r=rhunt

Depends on D240393

Comment 24

[Ben Visness [:bvisness]]

Attachment: Bug 1892721: Track ref types on global.get. r=rhunt

Depends on D240394

Comment 25

[Ben Visness [:bvisness]]

Attachment: Bug 1892721: Add debug result checks for wasm ref types. r=rhunt

This adds debug-only checks to ensure that any MIR node that declares a
wasm ref type actually produces values matching that type. This
essentially performs a ref.cast after each operation.

Comment 26

[Ben Visness [:bvisness]]

Attachment: Bug 1892721: Add static type defs to builtin type contexts. r=rhunt

Because the types in StaticTypeDefs.h were not actually added to the
type contexts for builtin modules, they would not work in cases where,
for example, we try to look up a type's index.

Comment 27

[Ben Visness [:bvisness]]

Attachment: Bug 1892721: Track ref types on select. r=rhunt

Also adds a simple foldsTo if the condition is constant. (I'm surprised
we didn't have this in place already.)

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ce87c043c9e
Track wasm ref types directly on MIR nodes. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/150e1c8e4b35
Add debug result checks for wasm ref types. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/e82e5ecbaf2e
Add static type defs to builtin type contexts. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/e3c914c3f41c
Track ref types on phis. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/ee1c3b9b7532
Track ref types on nulls. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/d86ec5a73d86
Track ref types on i31.new. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/cbeee30d81cd
Track ref types on new structs and arrays. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/29ed6f86d0c9
Track ref types on wasm parameters. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/2eeecc8ebd44
Track ref types on any <-> extern conversions. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/1674ea62221f
Track ref types on field/element loads. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/8968c113bd92
Track ref types on some MWasmRegisterResults. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/6d5115798ab7
Track ref types on table elems. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/483f296a7cf7
Track ref types on global.get. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/b904665b1626
Track ref types on select. r=rhunt

Comment 29

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1ce87c043c9e
https://hg.mozilla.org/mozilla-central/rev/150e1c8e4b35
https://hg.mozilla.org/mozilla-central/rev/e82e5ecbaf2e
https://hg.mozilla.org/mozilla-central/rev/e3c914c3f41c
https://hg.mozilla.org/mozilla-central/rev/ee1c3b9b7532
https://hg.mozilla.org/mozilla-central/rev/d86ec5a73d86
https://hg.mozilla.org/mozilla-central/rev/cbeee30d81cd
https://hg.mozilla.org/mozilla-central/rev/29ed6f86d0c9
https://hg.mozilla.org/mozilla-central/rev/2eeecc8ebd44
https://hg.mozilla.org/mozilla-central/rev/1674ea62221f
https://hg.mozilla.org/mozilla-central/rev/8968c113bd92
https://hg.mozilla.org/mozilla-central/rev/6d5115798ab7
https://hg.mozilla.org/mozilla-central/rev/483f296a7cf7
https://hg.mozilla.org/mozilla-central/rev/b904665b1626