1892778 - Modernize the enums in WritingMode, and some cleanup nearby

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Filed per bug 1610666 comment 5, there are still some enums in
https://searchfox.org/mozilla-central/rev/a3d520fca1a1ca29992cb3806245db25e41a8617/layout/generic/WritingModes.h#158-185

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1892778 Part 1 - Convert unknown writing mode value to constexpr variable. r?#layout

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1892778 Part 2 - Convert InlineDir and BlockDir to enum classes. r?#layout

Also, rewrite GetInlineDir() and GetBlockDir() to remove bit operations for
computing the InlineDir and BlockDir enum variants.

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1892778 Part 3 - Remove BidiDir and GetBidiDir(). r?#layout

Existing callers are using IsBidiLTR() and IsBidiRTL() to check the inline
flow direction. BidiDir and GetBidiDir() do not seem useful, and were only
used internally before this patch.

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1892778 Part 4 - Convert MOZ_ASSERT to static_assert in WritingModes.h. r?#layout

These assertions verify that the numeric values are consistent with
StyleWritingMode (aka WritingMode in servo). They won't change during
runtime, so they can be static_assert.

Also, the two index variables can be uint8_t instead of int.

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1892778 Part 5 - Rewrite helper methods to get rid of bit operations. r?#layout

During the conversion from enum to enum class for LogicalEdge in bug 1885695,
we drop the explicit numeric values its variants. After removing the bit
operations in these helpers, it makes the implementation less obscure.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97be1eff3e3f
Part 1 - Convert unknown writing mode value to constexpr variable. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/0505eaab18b4
Part 2 - Convert InlineDir and BlockDir to enum classes. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/f9b3829fcfa4
Part 3 - Remove BidiDir and GetBidiDir(). r=dholbert
https://hg.mozilla.org/integration/autoland/rev/e1ed82dd66ab
Part 4 - Convert MOZ_ASSERT to static_assert in WritingModes.h. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/074d29b6e81d
Part 5 - Rewrite helper methods to get rid of bit operations. r=dholbert

Comment 7

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/97be1eff3e3f
https://hg.mozilla.org/mozilla-central/rev/0505eaab18b4
https://hg.mozilla.org/mozilla-central/rev/f9b3829fcfa4
https://hg.mozilla.org/mozilla-central/rev/e1ed82dd66ab
https://hg.mozilla.org/mozilla-central/rev/074d29b6e81d