1892814 - Rework remote settings usage

Status: RESOLVED FIXED

(Application Services :: Suggest, enhancement, P3)

Description

[Ben Dean-Kawamura [:bdk]]

As discussed in https://bugzilla.mozilla.org/show_bug.cgi?id=1889986, our remote settings usage does not align with the recommended practices from the remote settings team. In particular, we should not be using any filters other than gt_last_modified. We should rework the component to follow their recommendations.

In particular this means:

• Not fetching previously unparsable particular suggestions by id. This should be easy to change. I think we may not even use this code anymore.
• Using the default sorting, rather than reverse sorting by mtime. Also easy, we can just reverse things on the client side.
• Not filtering by type. This is probably the hardest change, but not too bad. When fetching the records, we can skip the type filter, but then only fetch attachments for the types we care about. (Is this just reverting Michelle's PR?).

Comment 1

[Ben Dean-Kawamura [:bdk]]

Mathieu: is there a deadline for these changes? AFAICT, they don't seem too hard, but we're focusing on getting another project out the door, and I may be missing some of the work needed. If we got this done by Q3 would that be work for your team?

Going forward, how would it work if we wanted to start using some filter or wanted to request a new feature for the remote settings API? I don't think we have any plans to do that, but we'd just like to know the correct channels to use if we did.

Comment 2

[Mathieu Leplatre [:leplatrem]]

Thank you for following this up

is there a deadline for these changes?

Not really. The sooner the better of course, but shouldn't conflict with ongoing work.
Q3 sounds great!

Going forward, how would it work if we wanted to start using some filter or wanted to request a new feature for the remote settings API? I don't think we have any plans to do that, but we'd just like to know the correct channels to use if we did.

The development of the service happens here: https://github.com/mozilla/remote-settings/
This is where we can discuss ideas, write ADRs, etc.
On Slack we are in #delivery

Comment 3

[Ben Dean-Kawamura [:bdk]]

Sounds good to me as well. I'll keep you updated on the progress.

Comment 4

[Ben Dean-Kawamura [:bdk]]

This was done as part of https://github.com/mozilla/application-services/pull/6334.