Remove nsIImapService.fetchMessage() from public interface
Categories
(MailNews Core :: General, task)
Tracking
(thunderbird_esr115 wontfix, thunderbird126 wontfix)
People
(Reporter: benc, Assigned: mkmelin)
Details
Attachments
(1 file)
nsIImapService.fetchMessage() seems over-complicated, under-documented and not publicly used.
It's easy to remove from the public interface from the C++ point of view, but the IMAP-JS relies on it being part of the interface.
Magnus: got any opinion from the JS side?
I'll post my C++ patch here just because I'd already written it (and I like the idea of being ruthless about public interfaces), but It's really not a big deal if it never gets applied.
|
Reporter | |
Comment 1•29 days ago
|
||
|
Assignee | |
Comment 2•28 days ago
•
|
||
You're right this is not a great interface.
I think removing it is just a matter of shuffling around a bit of code to avoid some unnecessary indirection magic.
|
||
Updated•22 days ago
|
|
|
Assignee | |
Updated•21 days ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/1e74c5719795
Remove nsIImapService.fetchMessage() from public interface. r=BenC
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/7f5d26c07e3e Follow-up, fix debug errors. rs=bustage-fix DONTBUILD
Description
•