1892887 - gmp-clearkey doesn't work if the binary is called something other than "firefox"

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect)

Description

[Julien Cristau [:jcristau] (back August 18)]

Initially reported at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1069683:

It seems that the gmp code does not expect the executable to be called something other than firefox:

GMPChild::MakeCDMHostVerificationPaths calls AppendHostPath with /usr/lib/firefox-esr/firefox, but that file doesn't exist, so AppendHostPath fails, and we end up calling into VerifyCdmHost_0 with aNumFiles==2, which fails the assertion that it's equal to NumExpectedHostFiles (4).

Initially seen with Debian's "firefox-esr" package, where the binary is /usr/lib/firefox-esr/firefox-esr; Mike suggested I file this upstream since it could affect others like seamonkey.

Comment 1

[Mike Hommey [:glandium]]

This probably should use MOZ_APP_NAME. I don't think we have anything returning the executable name in the directory service, although it would be convenient to avoid the platform-specific stuff.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1892887 - Use MOZ_APP_NAME and XUL_DLL in GMPChild::MakeCDMHostVerificationPaths.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b3f4c19c12c
Use MOZ_APP_NAME and XUL_DLL in GMPChild::MakeCDMHostVerificationPaths. r=media-playback-reviewers,padenot

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1892887 - Use MOZ_APP_NAME and XUL_DLL in GMPChild::MakeCDMHostVerificationPaths.

Original Revision: https://phabricator.services.mozilla.com/D208311

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1892887 - Use MOZ_APP_NAME and XUL_DLL in GMPChild::MakeCDMHostVerificationPaths.

Original Revision: https://phabricator.services.mozilla.com/D208311

Comment 6

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: CDM doesn't work properly when application name is not firefox
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: It's a no-op for mozilla builds
• String changes made/needed: N/A
• Is Android affected?: no

Comment 7

[Phabricator Automation]

esr115 Uplift Approval Request

• User impact if declined: CDM doesn't work properly when application name is not firefox
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: It's a no-op for mozilla builds
• String changes made/needed: N/A
• Is Android affected?: no

Comment 8

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/8b3f4c19c12c

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2512c25071fb

Comment 10

[Donal Meehan [:dmeehan]]

:glandium this failed to land on ESR115. If you could take a look?
https://lando.services.mozilla.com/D208456/

Comment 11

[Mike Hommey [:glandium]]

(In reply to Donal Meehan [:dmeehan] from comment #10)

:glandium this failed to land on ESR115. If you could take a look?
https://lando.services.mozilla.com/D208456/

Refreshed the patch.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/dce433d07c13