1892959 - Stub out initial backup management UI inside of about:preferences

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

This UI should be hidden by default, but can be exposed by setting a preference. Let's say that pref is browser.backup.management.enabled.

The section should be in the General tab, between "Import Browser Data" and "Tabs". When the preference is disabled, about:preferences should be indistinguishable from what we ship today.

This should just be an initial stab at getting a section into about:preferences, so it doesn't include all of the bells and whistles. A static placeholder is fine.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

If strings are being added, this is also a good opportunity to add a Fluent file for this stuff. We're not going to want to actually update preferences.ftl, because the strings we're adding might change as content design iterates.

What I recommend we do is add a new "preview" Fluent file under browser/locales-preview, called browser/locales-preview/backupPreferences.ftl. Along with adding that file, an entry will need to go for it under browser/locales/jar.mn.

Then, we'll need to load backup-preferences.ftl in the about:preferences page by adding <link rel="localization" href="locales-preview/backupPreferences.ftl"/> around here.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1892959 - Stub out initial section for backup management within about:preferences. r?#backup-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d2a72296044
Stub out initial section for backup management within about:preferences. r=backup-reviewers,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,flod,Gijs,kpatenio

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser/components/preferences/tests/browser_bug731866.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/c4ef32ca5d7a6f0d04e83e3f59503d04283d18fe

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_bug731866.js | General elements should be visible (id=dataBackupGroup)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f605492e2ba
Stub out initial section for backup management within about:preferences. r=backup-reviewers,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,flod,Gijs,kpatenio

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2f605492e2ba