1892965 - Rename Sidebar launcher and SidebarUI

Status: RESOLVED FIXED

(Firefox :: Sidebar, task, P1)

Description

[Sarah Clements [:sclements]]

We've been referring to the new sidebar component as the "sidebar launcher", as it was a carry over from prototyping when the naming wasn't important. It doesn't reflect the agreed upon terminology with UX/product, so we should rename the sidebar-launcher.mjs and sidebar-launcher.css component to simply Sidebar.

I also think it'd be worth renaming browser-sidebar's module from SidebarUI to SidebarController, since those best reflects what its doing and what we want it to continue doing. It does have some menu building but its largely performing toggling actions for the sidebar panel, providing an API for extensions, and otherwise updating different things.

Comment 1

[Sarah Clements [:sclements]]

Attachment: Bug 1892965 - Rename SidebarUI and SidebarLauncher r=#sidebar-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75c44ff76360
Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing multiple failures

Backout link

Push with failures

Failure log // Failure log 2 // Failure log 3 // Failure log 4 // Failure log 5

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d618f467edc5
Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d618f467edc5