Closed Bug 1893005 Opened 2 years ago Closed 2 years ago

Release stack memory earlier

Categories

(Core :: JavaScript: WebAssembly, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: yury, Assigned: yury)

References

Details

Attachments

(1 file, 1 obsolete file)

It is possible to create an app that will call promising function multiple times. It would make sense to not immediately disascard a stack memory, but keep it alive for some time in a pool.

Severity: -- → N/A
Priority: -- → P2
Attachment #9400780 - Attachment is obsolete: true

The idea is based on the https://issues.chromium.org/issues/41491351 issue. With SM architecture the hit was insignificant but there was a regression.

The D209848 patch did not bring any improvements. My guess that pool management is as fast as just free/malloc operation.

The most of the speed up came from D209796. Using it as a solution to close this bug.

Summary: Create pool for discarded suspendable stacks in JSPI → Release stack memory earlier
Assignee: nobody → ydelendik
Attachment #9400680 - Attachment description: WIP: Bug 1893005 - [wasm-jspi] Release stack memory earlier. → Bug 1893005 - [wasm-jspi] Release stack memory earlier. r?bvisness
Status: NEW → ASSIGNED
Pushed by ydelendik@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c1069ab33764 [wasm-jspi] Release stack memory earlier. r=bvisness
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: