1893040 - [wpt-sync] Sync PR 45852 - DOM: Fix Observable predicate function

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45852 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45852
Details from upstream follow.

Dominic Farolino <[e-mail]> wrote:

DOM: Fix Observable predicate function

See https://github.com/WICG/observable/issues/140, for the issue about
Predicate having an index parameter.

R=[e-mail]

Bug: 40282760
Change-Id: I94fdfcf9317ec3e364f5636c3808c7a39d88c54e

Reviewed-on: https://chromium-review.googlesource.com/5478849
WPT-Export-Revision: ea5434a3b6e2801a2f51585e17285e775a6549a5

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b52def9957da33a77efc45b082bef52be8918d14

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 2 tests and 6 subtests

Status Summary

Firefox

OK : 2
FAIL: 12

Chrome

OK : 2
PASS: 10
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /dom/observable/tentative/observable-filter.any.html [wpt.fyi]
  • filter(): Returned Observable filters out results based on predicate: FAIL (Chrome: PASS)
  • filter(): Errors thrown in filter predicate are emitted to Observer error() handler: FAIL (Chrome: PASS)
  • filter(): Passes complete() through from source Observable: FAIL (Chrome: PASS)
  • filter(): Passes error() through from source Observable: FAIL (Chrome: PASS)
  • filter(): Upon source completion, source Observable teardown sequence happens after downstream filter complete() is called: FAIL (Chrome: PASS)
  • filter(): Index is passed correctly to predicate: FAIL (Chrome: FAIL)
• /dom/observable/tentative/observable-filter.any.worker.html [wpt.fyi]
  • filter(): Returned Observable filters out results based on predicate: FAIL (Chrome: PASS)
  • filter(): Errors thrown in filter predicate are emitted to Observer error() handler: FAIL (Chrome: PASS)
  • filter(): Passes complete() through from source Observable: FAIL (Chrome: PASS)
  • filter(): Passes error() through from source Observable: FAIL (Chrome: PASS)
  • filter(): Upon source completion, source Observable teardown sequence happens after downstream filter complete() is called: FAIL (Chrome: PASS)
  • filter(): Index is passed correctly to predicate: FAIL (Chrome: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c12b0a816ed6
[wpt PR 45852] - DOM: Fix Observable predicate function, a=testonly
https://hg.mozilla.org/integration/autoland/rev/96857fc5d128
[wpt PR 45852] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c12b0a816ed6
https://hg.mozilla.org/mozilla-central/rev/96857fc5d128