1893070 - [wpt-sync] Sync PR 45856 - Add expected labels to errant tests in display-contents-role-and-label.html

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45856 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45856
Details from upstream follow.

Nathan LaPre <[e-mail]> wrote:

Add expected labels to errant tests in display-contents-role-and-label.html

For issue: https://github.com/web-platform-tests/interop-accessibility/issues/121

There are some tests in display-contents-role-and-label.html that have class .ex-role-and-label (indicating they should have their labels tested) but have no data-expectedlabel attribute specifying the expected label. This discrepancy causes spurious test failures. This commit fixes the problem by adding data-expectedlabel attributes to the affected tests.

All tested browsers are currently failing these tests, but after merging these fixes they should all pass.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3be5b3bb3ee8d310abb2c8376dc5b3657955a289

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 138 subtests

Status Summary

Firefox

OK : 1
PASS: 132
FAIL: 6

Chrome

OK : 1
PASS: 120
FAIL: 18

Safari

OK : 1
PASS: 110
FAIL: 28

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-display/accessibility/display-contents-role-and-label.html [wpt.fyi]
  • Label: td as child of tr with display: contents, within table with display: flex, has cell role: FAIL (Chrome: PASS, Safari: FAIL)
  • Label: td as child of tr with display: contents, within table with role=table with display: flex, has cell role: FAIL (Chrome: PASS, Safari: FAIL)
  • Label: listitem within ul with display: contents, as child of div with display: grid, has listitem role: FAIL (Chrome: FAIL, Safari: FAIL)
  • Label: li, as child of ul with role list and display: contents, has listitem role: FAIL (Chrome: FAIL, Safari: FAIL)
  • Label: li, as child of ol with role list and display: contents, has listitem role: FAIL (Chrome: FAIL, Safari: FAIL)
  • Label: td within tr in table with role table, all with display: contents, has cell role: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e9b2070a314
[wpt PR 45856] - Add expected labels to errant tests in display-contents-role-and-label.html, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b77d06e37efb
[wpt PR 45856] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0e9b2070a314
https://hg.mozilla.org/mozilla-central/rev/b77d06e37efb