1893077 - [wpt-sync] Sync PR 45858 - Remove DCHECK() that is no longer valid with calc-size().

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45858 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45858
Details from upstream follow.

L. David Baron <[e-mail]> wrote:

Remove DCHECK() that is no longer valid with calc-size().

The rules for animation of calc-size() intentionally allow animation
between calc-size() expressions typed as something other than a
percentage (e.g., a sizing keyword) and a percentage. This animation
erases the percentage-ness from the type at all intermediate values.
This means the animation works correctly when the percentage basis is
definite, but is incorrect when the percentage basis is indefinite.
This is an intentional behavior compromise discussed in
https://github.com/w3c/csswg-drafts/issues/10220 .

This adds a few tests that would hit the removed DCHECK().

Bug: 313072
Change-Id: If5abd44475742272a4635293ddc12837f3ae7153
Reviewed-on: https://chromium-review.googlesource.com/5480311
WPT-Export-Revision: ce134f2808670b3c18886322ed590e2b7dec3454

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5ba8eef711667464788cf68e8a4761c5b97ff26

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=06eaaefd11809c5637323189a7b5d22676a89adb

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 962 subtests

## Status Summary

### Firefox
`OK`  : 1
`FAIL`: 962

### Chrome
`OK`  : 1
`PASS`: 776
`FAIL`: 186

### Safari
`OK`  : 1
`FAIL`: 962

## Links
[GitHub PR Head](https://wpt.fyi/results/?sha=368b403a5c6831def9b08684ea42d23ac7057f7c&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=368b403a5c6831def9b08684ea42d23ac7057f7c&label=pr_base)

## Details

(See attachment for full changes)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/569849b9209d
[wpt PR 45858] - Remove DCHECK() that is no longer valid with calc-size()., a=testonly
https://hg.mozilla.org/integration/autoland/rev/4502af77bdba
[wpt PR 45858] - Update wpt metadata, a=testonly

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/569849b9209d
https://hg.mozilla.org/mozilla-central/rev/4502af77bdba