Closed Bug 1893091 Opened 6 months ago Closed 6 months ago

[wpt-sync] Sync PR 45863 - [Highlight Pseudos] Correctly paint shadows

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Product:
Core
Component:
Layout: Generated Content, Lists, and Counters
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
127 Branch
Tracking Flags:
Tracking Status
firefox127 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45863 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45863
Details from upstream follow.

Stephen Chenney <schenney@chromium.org> wrote:

[Highlight Pseudos] Correctly paint shadows

All highlight pseudos apart from custom highlights support
text-shadow, but we were not computing overflow and we were
not correctly painting or clipping. Fix it.

Existing tests cover selection alone. New tests cover highlight
overlay painting, and standalone spelling, grammar and target-text.

Bug: 40276880
Change-Id: I07da6fb39a497f6ab07c8907128d87fa5554fbfc
Reviewed-on: https://chromium-review.googlesource.com/5480767
WPT-Export-Revision: 93d0ffe62f973730023710f8cf71c4ec2b050df5

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

TIMEOUT: 4

Chrome

FAIL : 4

Safari

FAIL : 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d7e32eea15db [wpt PR 45863] - [Highlight Pseudos] Correctly paint shadows, a=testonly https://hg.mozilla.org/integration/autoland/rev/b80e6c634d37 [wpt PR 45863] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d7e32eea15db
https://hg.mozilla.org/mozilla-central/rev/b80e6c634d37

Status: NEW → RESOLVED
Closed: 6 months ago
status-firefox127: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in before you can comment on or make changes to this bug.