1893106 - cubeb-coreaudio-rs crashing again on macOS 12

Status: VERIFIED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[Andreas Pehrson [:pehrsons]]

See bug 1866595 comment 24 which can happen with a built-in mic because of the vpio force-list introduced in bug 1880244.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1880244

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1893106 - Update cubeb-coreaudio-rs to cc58f92f28. r?padenot!

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1893106 - In Gecko don't disable VOICE on macOS 12. r?padenot!

cubeb-coreaudio-rs is now responsible for this.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox126 (beta) and tracked for firefox127 (nightly). However, the bug still has low severity.

:jimm, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c1d84f3ebd0
Update cubeb-coreaudio-rs to cc58f92f28. r=padenot
https://hg.mozilla.org/integration/autoland/rev/7fc57c6a8e77
In Gecko don't disable VOICE on macOS 12. r=padenot

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6c1d84f3ebd0
https://hg.mozilla.org/mozilla-central/rev/7fc57c6a8e77

Comment 7

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1893106 - Update cubeb-coreaudio-rs to cc58f92f28. r?padenot!

Original Revision: https://phabricator.services.mozilla.com/D208444

Comment 8

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1893106 - In Gecko don't disable VOICE on macOS 12. r?padenot!

cubeb-coreaudio-rs is now responsible for this.

Original Revision: https://phabricator.services.mozilla.com/D208445

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Firefox parent process may crash when macOS 12 users capture their builtin microphone.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See bug 1866595 comment 9
• Risk associated with taking this patch: Low risk
• Explanation of risk level: We're moving some conditionals to change how one of two well-tested paths get taken on macOS 12.
• String changes made/needed: None
• Is Android affected?: no

Comment 10

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Firefox parent process may crash when macOS 12 users capture their builtin microphone.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See bug 1866595 comment 9, making sure you use the builtin microphone when testing.
• Risk associated with taking this patch: Low risk
• Explanation of risk level: We're moving some conditionals to change how one of two well-tested paths get taken on macOS 12.
• String changes made/needed: None
• Is Android affected?: no

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/fa6f9710260a
https://hg.mozilla.org/releases/mozilla-beta/rev/801293630edf

Comment 12

[Oana Botisan, Desktop QA]

Verified the fix using latest Nightly 127.0a1 om macOS 12. Couldn't reproduce the issue anymore.

However on Firefox 126.0b6 the issue is still reproducing. I guess I have to wait for Firefox 126.0b7 to verify the fix on beta.

Comment 13

[Donal Meehan [:dmeehan]]

(In reply to Oana Botisan, Desktop QA from comment #12)

I guess I have to wait for Firefox 126.0b7 to verify the fix on beta.

Correct, the fix was uplifted to beta after 126.0b6 was built. It's available in 126.0b7.

Comment 14

[Oana Botisan, Desktop QA]

Thank you for your response.
Verified the fix on Firefox 126.0b7 using macOS 12. I can't seem to be able to reproduce the issue anymore.

Comment 15

[Steven Michaud [:smichaud] (Retired)]

These crashes are not fixed.

https://crash-stats.mozilla.org/search/?modules_in_stack=~audiodsp&version=128.0b&platform=Mac%20OS%20X&date=%3E%3D2024-06-08T15%3A29%3A00.000Z&date=%3C2024-07-08T15%3A29%3A00.000Z&_facets=signature&_facets=platform_version&_facets=version&_facets=cpu_arch&_facets=proto_signature&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-proto_signature

Comment 16

[Paul Adenot (:padenot)]

Steven, there are unfortunately issues outside our control here, we're in contact with Apple, that has acknowledged the issue. We've disabled this new code path on most macOS version (on which the problem is happening more frequently), but left it enabled in the most recent version, where the problems exist but is rare.

Comment 17

[Steven Michaud [:smichaud] (Retired)]

This is definitely an Apple bug, and there's probably nothing Mozilla can do about it ... besides reporting it to Apple. I'm glad that's been done.

I just wanted to make people aware that these crashes haven't been fixed, or even reduced in frequency.