1893200 - [wpt-sync] Sync PR 45878 - Revert "Reapply "Use typed promises/resolvers for ReadableStream and related classes""

Status: RESOLVED FIXED

(Core :: DOM: Performance, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45878 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45878
Details from upstream follow.

Nate Chapin <[e-mail]> wrote:

Revert "Reapply "Use typed promises/resolvers for ReadableStream and related classes""

This reverts commit 39adf0544a3fbfcce710b0490d3825174c0c6e12.

Reason for revert: Crashes in the wild: crbug.com/332806529

Original change's description:

Reapply "Use typed promises/resolvers for ReadableStream and related classes"

This converts IDL-exposed promises in ReadableStream,
ReadableStreamBYOBReader, ReadableStreamDefaultReader, and
ReadableStreamGenericReader to use typed ScriptPromiseResolver
instead of StreamPromiseResolver and to return typed
ScriptPromises.

Bug: 329702363
Change-Id: I6dad0ce6902c2dd5411185800bdd5a6dd8585df8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410703
Reviewed-by: Nidhi Jaju \<[e-mail]>
Commit-Queue: Nate Chapin \<[e-mail]>
Reviewed-by: Adam Rice \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1281906}

Bug: 329702363
Change-Id: I2a70811f87d844a1686fc082d67c8dbc473f91c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5427820
Commit-Queue: Nate Chapin \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1283318}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc6251c42c75188ebe060b5187d0ef97e7b74f98

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 3 subtests

Status Summary

Firefox

ERROR: 2

Chrome

OK : 2
PASS : 4

Safari

ERROR: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /long-animation-frame/tentative/loaf-stream-source-location.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
• /long-animation-frame/tentative/loaf-stream.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e3c25dc89dd
[wpt PR 45878] - Revert "Reapply "Use typed promises/resolvers for ReadableStream and related classes"", a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6e3c25dc89dd