Open Bug 1893220 Opened 3 months ago Updated 3 months ago

Factor out schema-validation functions in BackupService into something shared

Categories

(Firefox :: Profile Backup, task, P3)

Product:
Firefox
Component:
Profile Backup
Type:
task

Tracking

()

People

(Reporter: mconley, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-device-migration])

We check the backup-manifest.json against a schema both after creating the backup, and when recovering from one. In the former case, we only log an error if for some reason we created an invalid schema (which really really really shouldn't happen, but we want to log an error for it, and maybe eventually collect Telemetry for that case to ensure it's not happening in the wild).

In the recovery case though, we definitely want to make sure that the backup-manifest.json matches our schema, and it should be fatal if it doesn't.

In any case, we're doing this kind of schema checking in two places, and fchasen brought up the good point that this can probably be factored out into a shared private helper method on BackupService.

Whiteboard: [fidefe-device-migration]
You need to log in before you can comment on or make changes to this bug.