1893257 - Firefox-only failures in WPT fetch/http-cache/cache-mode.any.js

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect, P2)

Description

[Thomas Wisniewski [:twisniewski]]

See https://wpt.fyi/results/fetch/http-cache?q=%2Fcache-mode

Fixing this essentially boils down to not setting the pragma and cache-control headers if they're not already set in nsHttpChannel.

We also fail the test Fetch sends Cache-Control: max-age=0 when cache mode is no-cache unless the check for !LoadCacheEntryIsWriteOnly() here is removed.

Comment 1

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1893257 - don't overwrite pragma or cache-control request headers per spec, and otherwise always set cache-control:max-age=0 for no-cache cache mode; r?valentin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42813f04d4f6
don't overwrite pragma or cache-control request headers per spec, and otherwise always set cache-control:max-age=0 for no-cache cache mode; r=valentin,necko-reviewers

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/42813f04d4f6