Closed Bug 1893347 Opened 7 months ago Closed 7 months ago

[wpt-sync] Sync PR 45896 - [css-flex] Include gaps in intrinsic sizes for column-wrap flexboxes

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
127 Branch
Tracking Flags:
Tracking Status
firefox127 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45896 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45896
Details from upstream follow.

David Grogan <dgrogan@chromium.org> wrote:

[css-flex] Include gaps in intrinsic sizes for column-wrap flexboxes

The intrinsic sizing code borrows PlaceFlexItems from Layout, but
PlaceFlexItems doesn't handle gaps, AlignFlexLines does. We don't want to
bring all of AlignFlexLines into intrinsic sizing, so just add gaps
manually.

Fixed: 335328452
Change-Id: Ic97b04ab22766a894299a3b74d0feea3734041fc
Reviewed-on: https://chromium-review.googlesource.com/5486047
WPT-Export-Revision: cda3ebc4f31ddf8825883c21c6dc70cb883f249f

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b0a42eac6a0c [wpt PR 45896] - [css-flex] Include gaps in intrinsic sizes for column-wrap flexboxes, a=testonly https://hg.mozilla.org/integration/autoland/rev/482aaa763c91 [wpt PR 45896] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/b0a42eac6a0c
https://hg.mozilla.org/mozilla-central/rev/482aaa763c91

Status: NEW → RESOLVED
Closed: 7 months ago
status-firefox127: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in before you can comment on or make changes to this bug.