1893434 - Migrate (copy) user interaction flags from the permission manager to BTP interaction store

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P1)

Description

[Paul Zühlcke [:pbz]]

Enabling BTP on existing profiles may lead to false positives since the user interaction store has not been warmed up yet.
We could warm up via keeping the mechanism in dry-run mode for a while. That doesn’t work for profiles that do version jumps though, including ESR.
A better solution is importing the existing user activation permissions to BTP user interaction store.
We should do this in the BTP code based on a “hasMigrated” pref since the migration needs to run on Android as well. The migration should only run once when the feature is first enabled.

Comment 1

[Paul Zühlcke [:pbz]]

Attachment: Bug 1893434 - Import user activation signals from permission manager into BTP user activation store. r=bvandersloot,manuel

Comment 2

[Paul Zühlcke [:pbz]]

Attachment: Bug 1893434 - Test, r=bvandersloot,manuel

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2662a25f169
Import user activation signals from permission manager into BTP user activation store. r=manuel,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/f85c87baf5db
Test, r=manuel,anti-tracking-reviewers

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing xpcshell failures on test_bouncetracking_importUserActivationPermissions.js

Backout link

Push with failures

Failure log

Comment 5

[Paul Zühlcke [:pbz]]

The MOZ_ASSERT was a bit too strict as the clock advances further before the permission manager fetches the permissions. Removed that part of the check.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb1dff3416a0
Import user activation signals from permission manager into BTP user activation store. r=bvandersloot,manuel,anti-tracking-reviewers
https://hg.mozilla.org/integration/autoland/rev/26390589f165
Test, r=manuel,anti-tracking-reviewers

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fb1dff3416a0
https://hg.mozilla.org/mozilla-central/rev/26390589f165